[syslog-ng] fsf address, embedded date

[Peter Czanik]

Hello,
While working on the openSUSE package, I ran into this problem. Post
compile checks brought up this problem:

syslog-ng.x86_64: W: incorrect-fsf-address
/usr/share/syslog-ng/include/scl/system/plugin.conf
syslog-ng.x86_64: W: incorrect-fsf-address
/usr/share/syslog-ng/include/scl/syslogconf/plugin.conf
syslog-ng.x86_64: W: incorrect-fsf-address
/usr/share/syslog-ng/include/scl/pacct/plugin.conf
syslog-ng.x86_64: W: incorrect-fsf-address /etc/syslog-ng/scl.conf
syslog-ng.x86_64: W: incorrect-fsf-address
/usr/share/syslog-ng/include/scl/system/generate-system-source.sh
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license
file,
possibly the entire file with a new copy available from the FSF.

There is another one I usually fix with a patch:

syslog-ng.x86_64: W: file-contains-date-and-time /sbin/syslog-ng
Your file uses  __DATE and __TIME__ this causes the package to rebuild when
not needed

The reasoning behind this is, that if a package is recompiled for some
reason, but results in the binary same files, then dependent packages
are not recompiled. But if date is embedded, then it changes on each
build...
For syslog-ng-3.3.0beta1 it was this patch:

linux-1wrf:~/home:czanik:syslog-ng33/syslog-ng # cat
1/syslog-ng-3.3.0beta1-no-datetime.diff
--- syslog-ng/main.c.orig    2011-05-24 17:32:35.696000107 +0200
+++ syslog-ng/main.c    2011-05-24 17:33:04.886000067 +0200
@@ -128,7 +128,9 @@
   printf(PACKAGE " " VERSION "\n"
          "Installer-Version: %s\n"
          "Revision: " SOURCE_REVISION "\n"
+#if 0
          "Compile-Date: " __DATE__ " " __TIME__ "\n"
+#endif
          "Default-Modules: %s\n"
          "Available-Modules: ",
          installer_version,

Bye,

-- 
Peter Czanik (CzP) <czanik at balabit.hu>
BalaBit IT Security / syslog-ng upstream
http://czanik.blogs.balabit.com/