[syslog-ng] [PATCH 2/3] afmongodb: Port to value-pairs().

[Balazs Scheidler]

On Sun, 2011-05-01 at 09:32 +0200, Gergely Nagy wrote:
> Balazs Scheidler <bazsi at balabit.hu> writes:
> 
> > On Sun, 2011-04-24 at 11:29 +0200, Gergely Nagy wrote:
> >> Ported from custom, explicit key/value pairs to the far more flexible
> >> value-pairs() solution. By default, the driver uses a custom scope:
> >> selected_macros and nv_pairs, with a few patterns excluded.
> >> 
> >> The patch also turns the collection() parameter into a plain string
> >> (from a templatable string), to considerably reduce the work needed to
> >> insert messages into the database.
> >> 
> >> Signed-off-by: Gergely Nagy <algernon at balabit.hu>
> >
> > I've rebased this patch and adapted it to my value-pairs changes. Can
> > you please check if it works for you?
> 
> It's not on your master branch, neither in 3.3 nor in 3.4, as far as I
> see. I can reach the patch on git.balabit.hu via gitweb, but a cloned
> repository does not have it.

hmm, I don't understand, it is on the master branch, like all the
others. Are you sure you properly cloned the repo? Can you try to
explicitly check out origin/master ?

> 
> I looked through the patch on the web though, and I believe it's
> correct, and should work. One comment though, regarding the commit
> message: you moved the collection name un-templating to a separate
> patch, so you might want to delete that part of the commit message :)

Well, you submitted that portion in a separate email, so I've just
committed them separately.

> 
> I'll download & apply the patch by hand later today, if time allows, and
> test it properly. But I'm fairly sure it'll work.
> 

would be great. I just compile tested it.

Can you point me to a simple description for the simplest ever usecase
for the mongodb destination? So that I can test it when I apply a
change.

-- 
Bazsi