[syslog-ng] [PATCH 2/3] afmongodb: Port to value-pairs().

Gergely Nagy algernon at balabit.hu
Sun May 1 09:32:11 CEST 2011

Balazs Scheidler <bazsi at balabit.hu> writes:

> On Sun, 2011-04-24 at 11:29 +0200, Gergely Nagy wrote:
>> Ported from custom, explicit key/value pairs to the far more flexible
>> value-pairs() solution. By default, the driver uses a custom scope:
>> selected_macros and nv_pairs, with a few patterns excluded.
>> The patch also turns the collection() parameter into a plain string
>> (from a templatable string), to considerably reduce the work needed to
>> insert messages into the database.
>> Signed-off-by: Gergely Nagy <algernon at balabit.hu>
> I've rebased this patch and adapted it to my value-pairs changes. Can
> you please check if it works for you?

It's not on your master branch, neither in 3.3 nor in 3.4, as far as I
see. I can reach the patch on git.balabit.hu via gitweb, but a cloned
repository does not have it.

I looked through the patch on the web though, and I believe it's
correct, and should work. One comment though, regarding the commit
message: you moved the collection name un-templating to a separate
patch, so you might want to delete that part of the commit message :)

I'll download & apply the patch by hand later today, if time allows, and
test it properly. But I'm fairly sure it'll work.


More information about the syslog-ng mailing list