[syslog-ng] [development] open questions

Balazs Scheidler bazsi at balabit.hu
Sun Feb 20 13:22:04 CET 2011


On Sun, 2011-02-06 at 18:13 +0100, Gergely Nagy wrote:
> > $(format-json) template function (Balint, Algernon, Matthew)
> > 
> >    * waiting for the generic value-pairs() implementation 
> > 
> >    * it could probably be added to 3.2 as well, if value-pairs 
> >      doesn't prove to be risky in itself (or else they'd have to be 
> >      put in the tfjson module).
> 
> Matthew backported the non-value-pairs() version to 3.2 already. I'm not
> sure whether it's worth adding value-pairs() to 3.2 - even if it's
> reasonably easy and self-contained code, it's still seems too big for
> 3.2.
> 
> On the other hand, if it's deemed worthy enough, I'll happily backport
> both value-pairs() and tfjson() to 3.2.
> 
> However, before all that, value-pairs() needs to be finished. I plan to
> write a status report tonight.

I'll have a look and decide based on that.

> 
> > systemd support (Marius Tomaschewski, Tom Gundersen, Algernon)
> > 
> >    * should be more-or-less ready, Algernon promised to rebase it
> >      against both 3.2 and 3.3 , so that I 
> >      can integrate into both.
> 
> This is available from the integration/systemd branches of my 3.2 and
> 3.3 trees:
> 
> git://git.madhouse-project.org/syslog-ng/syslog-ng-3.2.git and
> git://git.madhouse-project.org/syslog-ng/syslog-ng-3.3.git
> 
> The integration branch was based on the current master of of each
> version, and contains two commits: one that makes GSockAddr->sa_funcs
> per-instance instead of per-family.
> 
> On top of this is Marius' systemd socket activation support (condensed
> into a single commit, including my inherit_systemd_activation()
> cleanup).
> 

I have now pulled your latest patches into both 3.2 and 3.3 (the one
which implements my afsocket_acquire_socket() virtual method
suggestion), so now both syslog-ng 3.2 & 3.3 sports systemd support.

Great work, thanks.

-- 
Bazsi




More information about the syslog-ng mailing list