[syslog-ng] syslog-ng 2.0.4 How can syslog-ng achievethisperformance???

[Balazs Scheidler]

On Wed, 2007-06-20 at 10:44 +0100, Geller, Sandor (IT) wrote:
> > diff --git a/src/logwriter.c b/src/logwriter.c
> > index eea6814..955c333 100644
> > --- a/src/logwriter.c
> > +++ b/src/logwriter.c
> > @@ -499,7 +499,7 @@ log_writer_options_init(LogWriterOptions 
> > *options, GlobalConfig *cfg, guint32 fl
> >    options->template = template;
> >    options->flags = flags;
> >    if (options->fifo_size == -1)
> > -    options->fifo_size = MIN(1000, cfg->log_fifo_size);
> > +    options->fifo_size = MAX(1000, cfg->log_fifo_size);
> >    if (options->use_time_recvd == -1)
> >      options->use_time_recvd = cfg->use_time_recvd;
> 
> With this patch there will be a problem when someone tries to use
> log_fifo_size lower than 1000 :) Why not using the same value as
> cfg->log_fifo_size? It defaults to 1000, so you'll set up a sane
> value if there wasn't log_fifo_size specified in the config file.
> Another solution would be to sanitise the value later, and send a
> warning message when it needs to be fixed.

That was my intention. I don't want to allow anything lower than 1000,
with the latest multi-fetch patches (in 1.6.11 and 2.0.x), anything
lower than 1000 may be dropping messages even when the destination is a
file. 

-- 
Bazsi