[syslog-ng]preparing syslog-ng 1.6.6
Balazs Scheidler
syslog-ng@lists.balabit.hu
Thu, 03 Feb 2005 12:09:39 +0100
On Thu, 2005-02-03 at 11:53 +0100, Roberto Nibali wrote:
> > are you sure you want to add the condition as displayed above? that
> > would mean that only dgram sockets will have this check, however it is
> > more common to exceed line lengths with stream oriented sockets.
> >
> > I think you wanted something like
> >
> > if (!eol && closure->pos == closure->max_log_line) {
> > werror("Message length overflow (ignored the rest)\n");
> > }
> >
> > Please confirm, then I could add the patch.
>
> Absolutely. I was mislead by the enclosing if (closure->dgram ...) into
> thinking do_read_line() only handles dgrams. If you would be so kind as
> to include your version of this patch, I'd be much delighted.
Added. Though the snapshot I've uploaded 5 minutes ago still does not
contain it. Look for it tomorrow (clarified the message somewhat, and
moved the check above the trailing NL and NUL character check)
--
Bazsi