[syslog-ng]preparing syslog-ng 1.6.6
Roberto Nibali
syslog-ng@lists.balabit.hu
Thu, 03 Feb 2005 11:53:12 +0100
Hi Bazsi,
>>Ok, the following patch has been applied and works (it's not in the Changelog
>>however), so I can verify this to be fixed:
>
> added the changelog entry.
Thanks, it's not for the fame :), just for QA and synchronisation with
our internal bugzilla.
> are you sure you want to add the condition as displayed above? that
> would mean that only dgram sockets will have this check, however it is
> more common to exceed line lengths with stream oriented sockets.
>
> I think you wanted something like
>
> if (!eol && closure->pos == closure->max_log_line) {
> werror("Message length overflow (ignored the rest)\n");
> }
>
> Please confirm, then I could add the patch.
Absolutely. I was mislead by the enclosing if (closure->dgram ...) into
thinking do_read_line() only handles dgrams. If you would be so kind as
to include your version of this patch, I'd be much delighted.
> I think the same patch is already applied. At least this is what I see
> here:
>
> if (closure->dgram || (!eol && closure->pos == closure->max_log_line)) {
> /* we don't have a terminating nl nor \0, and our buffer is
> full or we are a datagram receiver, when the message is in
> its own packet.
> */
Indeed. I wonder what I was looking at ... so no need to further look
into this. Excellent: -2 patches on our side :).
Thanks for you cooperation,
Roberto Nibali, ratz
--
echo
'[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc