[syslog-ng] FW: Mark from 1.9.4 to 1.9.5

[Roberto Nibali]

Hello,

Would you mind not sending your emails in html? I have to hand-edit them
to make them readable. It's only a suggestion.

> My only option left is to hack the source and remove the function and
> the reference to it –

Interesting, indeed.

> Anyone have any other suggestions for getting rid of the Mark ???

Maybe setting mark_freq(0); ??

> Is there a compile time option to turn this off???
> Even stranger is that the source declares:
> cfg.c:  self->mark_freq = 1200; /* 20 minutes */
> but I am seeing a mark once an hour

log_msg_new_mark() will generate this message, it's only called once.

static gboolean
log_reader_fd_dispatch(GSource *source,
                       GSourceFunc callback,
                       gpointer user_data)
{
  LogReaderWatch *self = (LogReaderWatch *) source;
  GTimeVal tv;

  g_source_get_current_time(source, &tv);

  if (self->reader->mark_target != -1 && self->reader->mark_target <=
tv.tv_sec)
    {
      log_pipe_queue(&self->reader->super.super, log_msg_new_mark(),
PF_FLOW_CTL_OFF);

[send/queue the MARK message: once it's queue it's going to be written]

    }

  if (self->reader->options->mark_freq > 0)

[This is almost always the case]

    {
      g_source_get_current_time(source, &tv);
      self->reader->mark_target = tv.tv_sec +
self->reader->options->mark_freq;
    }

  if (!log_reader_fetch_log(self->reader, self->fd))
    {
      return FALSE;
    }

  return TRUE;
}

This indeed looks a bit funky to me. Let's wait for the master. Another
interesting thing is the function afinet_dd_set_sync_freq() in afinet.c
which seems to be called from the cfg-gammar.y yacc. It's void. Is there
maybe some code missing?

Regards,
Roberto Nibali, ratz
-- 
-------------------------------------------------------------
addr://Rathausgasse 31, CH-5001 Aarau  tel://++41 62 823 9355
http://www.terreactive.com             fax://++41 62 823 9356
-------------------------------------------------------------
terreActive AG                       Wir sichern Ihren Erfolg
-------------------------------------------------------------