[Bug 219] New: log_msg_is_write_protected when a source is used in multiple log statments
https://bugzilla.balabit.com/show_bug.cgi?id=219 Summary: log_msg_is_write_protected when a source is used in multiple log statments Product: syslog-ng Version: 3.4.x Platform: PC OS/Version: Linux Status: NEW Severity: critical Priority: unspecified Component: syslog-ng AssignedTo: bazsi@balabit.hu ReportedBy: erempel@uvic.ca Type of the Report: --- Estimated Hours: 0.0 Created an attachment (id=71) --> (https://bugzilla.balabit.com/attachment.cgi?id=71) minimal syslog-ng.conf It appears that if a source is used in two different log statements, all branches use a write protected instance of the log message. Module loaded and initialized successfully; module='syslogformat' Running application hooks; hook='1' Running application hooks; hook='3' syslog-ng starting up; version='3.4.1' Syslog connection accepted; fd='12', client='AF_INET(142.104.141.3:40576)', local='AF_INET(0.0.0.0:514)' Incoming log entry; line='<134>2013-02-04T15:28:46-08:00 pangolin.comp.uvic.ca/pangolin.comp.uvic.ca action-handler[24020]: starting' Initializing destination file writer; template='/var/syslog/archive.log', filename='/var/syslog/archive.log' Filter node evaluation result; result='not-match' Filter node evaluation result; result='not-match', type='filter(f_short_host_at)' ** ERROR:logmsg.c:535:log_msg_set_value_indirect: assertion failed: (!log_msg_is_write_protected(self)) Attached is a very simple config file that reproduces this issue. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=219 --- Comment #1 from Evan Rempel <erempel@uvic.ca> 2013-02-05 18:43:19 --- hmmm, it is even more subtle than that. IF I use a single log statement of log { source(unix_network_tcp); rewrite(r_short_host); destination(d_files); destination(d_archive); }; all works well, but if I use the log statement log { source(unix_network_tcp); destination(d_files); rewrite(r_short_host); destination(d_archive); }; I get the log_msg_is_write_protected failure. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=219 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.4.2 CC| |algernon@balabit.hu AssignedTo|bazsi@balabit.hu |algernon@balabit.hu --- Comment #2 from Gergely Nagy <algernon@balabit.hu> 2013-02-08 12:14:06 --- I have a rough idea how to fix this, will try to push a patch soon. Thanks for the report! -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=219 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=219 Balazs Scheidler <bazsi@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bazsi@balabit.hu --- Comment #3 from Balazs Scheidler <bazsi@balabit.hu> 2013-02-12 21:47:47 --- I have a fix on the protected-logmsg-in-filters-assertion-fix branch, that seems to fix the issue for me. Algernon, can you please merge that to master? -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=219 --- Comment #4 from Balazs Scheidler <bazsi@balabit.hu> 2013-02-13 09:47:30 --- Maybe my reference to the branch wasn't clear, it is in the syslog-ng-3.4 repository on github: https://github.com/balabit/syslog-ng-3.4/tree/protected-logmsg-in-filters-as... -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=219 --- Comment #5 from Gergely Nagy <algernon@balabit.hu> 2013-02-13 10:01:09 --- It was clear (but even if it wouldn't have been, I see all syslog-ng related activity on github anyway :), I'll pick it over to master later today, thanks! -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=219 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution| |FIXED Status|ASSIGNED |RESOLVED --- Comment #6 from Gergely Nagy <algernon@balabit.hu> 2013-02-14 14:37:36 --- Merged to master, marking it resolved. Thanks for the report, and for the patch too! -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla＠bugzilla.balabit.com