3.4 alpha: Deadlock in MongoDB plugin?
Hi, it's me bugging again :) (btw, I'm on the list, no need to CC me) In my quest to test my patches with the actual 3.4 version syslog, I noticed today that the mongodb plugin doesn't seem to work very at all on todays master branch (vanilla, without any patches). No log messages are ever written to the DB, and after a few messages syslog locks up. The mongodb threads seems to idle in its normal event loop while the main thread seems to be stuck in some afmongodb-related lock. Once again, I need to go to bed before I can take a closer look, but I just thought I'd let you know. Find here a backtrace of the main thread in the state it is stuck in: http://pastebin.com/QZSam3CH At the bottom is also the backtrace for the mongodb thread, as far as I can tell it looks as always. Good night for now, Conrad
Conrad Hoffmann <ch@bitfehler.net> writes:
No log messages are ever written to the DB, and after a few messages syslog locks up.
The mongodb threads seems to idle in its normal event loop while the main thread seems to be stuck in some afmongodb-related lock.
That sounds familiar, can you try if this patch fixes it for you? https://github.com/algernon/syslog-ng/commit/7b6280a183e1edec0be2e6b2b0b4bca... (On the hotfix/3.4/afmongodb-notify-deadlock of my repo[1]) [1]: git://github.com/algernon/syslog-ng.git If that works, then I really, really need to get back to working on LogThreadedDestdriver, and get rid of these things once and for all. -- |8]
On 08/14/2012 08:15 AM, Gergely Nagy wrote:
That sounds familiar, can you try if this patch fixes it for you?
It does indeed... messages are properly written to MongoDB and no lockup after 15 messages (used to be after 2 or 3). If there is anything I can do to help you fix it, let me know (provide system details, test stuff, whatever).
https://github.com/algernon/syslog-ng/commit/7b6280a183e1edec0be2e6b2b0b4bca...
(On the hotfix/3.4/afmongodb-notify-deadlock of my repo[1])
[1]: git://github.com/algernon/syslog-ng.git
If that works, then I really, really need to get back to working on LogThreadedDestdriver, and get rid of these things once and for all.
Conrad Hoffmann <ch@bitfehler.net> writes:
On 08/14/2012 08:15 AM, Gergely Nagy wrote:
That sounds familiar, can you try if this patch fixes it for you?
It does indeed... messages are properly written to MongoDB and no lockup after 15 messages (used to be after 2 or 3).
If there is anything I can do to help you fix it, let me know (provide system details, test stuff, whatever).
Well, the aforementioned patch is the fix, and you just tested it :) -- |8]
On 08/14/2012 09:51 AM, Gergely Nagy wrote:
Conrad Hoffmann <ch@bitfehler.net> writes:
On 08/14/2012 08:15 AM, Gergely Nagy wrote:
That sounds familiar, can you try if this patch fixes it for you?
It does indeed... messages are properly written to MongoDB and no lockup after 15 messages (used to be after 2 or 3).
If there is anything I can do to help you fix it, let me know (provide system details, test stuff, whatever).
Well, the aforementioned patch is the fix, and you just tested it :)
Hehe, ok, it sounded like a lot more work. But in this case: nice job ;)
participants (2)
-
Conrad Hoffmann
-
Gergely Nagy