[Bug 111] New: RPM build errors: Installed (but unpackaged) file(s) found:
https://bugzilla.balabit.com/show_bug.cgi?id=111 Summary: RPM build errors: Installed (but unpackaged) file(s) found: Product: syslog-ng Version: 3.2.x Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: unspecified Component: packaging AssignedTo: folti@balabit.hu ReportedBy: owen.mann@interactivedata.com Type of the Report: bug Estimated Hours: 0.0 when attempting `rpmbuild -tb syslog-ng_3.2beta1.tar.gz`, the compilation completes, but: [...] Checking for unpackaged file(s): /usr/lib/rpm/check-files /var/tmp/syslog-ng-root error: Installed (but unpackaged) file(s) found: /bin/pdbtool /bin/update-patterndb /etc/syslog-ng/modules.conf /etc/syslog-ng/scl.conf /lib/libsyslog-ng.la /lib/libsyslog-ng.so /lib/libsyslog-ng.so.0 /lib/libsyslog-ng.so.0.0.0 /lib/syslog-ng/libaffile.la /lib/syslog-ng/libaffile.so /lib/syslog-ng/libafprog.la /lib/syslog-ng/libafprog.so /lib/syslog-ng/libafsocket-notls.la /lib/syslog-ng/libafsocket-notls.so /lib/syslog-ng/libafsocket-tls.la /lib/syslog-ng/libafsocket-tls.so /lib/syslog-ng/libafsocket.so /lib/syslog-ng/libafuser.la /lib/syslog-ng/libafuser.so /lib/syslog-ng/libbasicfuncs.la /lib/syslog-ng/libbasicfuncs.so /lib/syslog-ng/libconfgen.la /lib/syslog-ng/libconfgen.so /lib/syslog-ng/libconvertfuncs.la /lib/syslog-ng/libconvertfuncs.so /lib/syslog-ng/libcsvparser.la /lib/syslog-ng/libcsvparser.so /lib/syslog-ng/libdbparser.la /lib/syslog-ng/libdbparser.so /lib/syslog-ng/libdummy.la /lib/syslog-ng/libdummy.so /lib/syslog-ng/libsyslogformat.la /lib/syslog-ng/libsyslogformat.so /sbin/syslog-ng-ctl /share/include/scl/pacct/plugin.conf /share/include/scl/syslogconf/README /share/include/scl/syslogconf/convert-syslogconf.awk /share/include/scl/syslogconf/plugin.conf /share/include/scl/system/generate-system-source.sh /share/include/scl/system/plugin.conf /share/xsd/patterndb-1.xsd /share/xsd/patterndb-2.xsd /share/xsd/patterndb-3.xsd [...] If these files are added to the %files section in syslog-ng.spec, the build completes successfully. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=111 Balazs Scheidler <bazsi@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bazsi@balabit.hu --- Comment #1 from Balazs Scheidler <bazsi@balabit.hu> 2011-02-06 07:10:31 --- could you please post your patch against the spec file, please? don't forget to add signed-off-by to your submission. Thanks. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=111 Balazs Scheidler <bazsi@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jpo@di.uminho.pt Resolution| |FIXED Status|NEW |RESOLVED --- Comment #2 from Balazs Scheidler <bazsi@balabit.hu> 2011-10-23 09:22:16 --- I'm not completely sure if the syslog-ng.spec file in the source distribution would work for anyone. Since I don't regularly build rpm using that file, I'm considering to remove it. Jose, could you perhaps update the spec file based on the fedora packaging and post a patch to do that? Thanks. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=111 Matthias Runge <mrunge@fedoraproject.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mrunge@fedoraproject.org --- Comment #3 from Matthias Runge <mrunge@fedoraproject.org> 2011-10-24 13:21:01 --- Latest spec is here (for syslog-ng-3.2.5) I'm not sure, if this spec file will work for open suse; I'm pretty sure, it won't work e.g. for EPEL 4. (branch overview) http://pkgs.fedoraproject.org/gitweb/?p=syslog-ng.git;a=commit;h=38ce8d6151f... direct link to spec file: http://pkgs.fedoraproject.org/gitweb/?p=syslog-ng.git;a=blob_plain;f=syslog-... -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=111 --- Comment #4 from Jose Oliveira <jpo@di.uminho.pt> 2011-10-25 23:09:20 --- (In reply to comment #2)
I'm not completely sure if the syslog-ng.spec file in the source distribution would work for anyone. Since I don't regularly build rpm using that file, I'm considering to remove it.
Jose, could you perhaps update the spec file based on the fedora packaging and post a patch to do that? Thanks.
I'll give it a try but maintaining a single specfile for the major RPM based distros will be extremely hard to achieve. For instance, for the Fedora Project we are already maintaining several sets of syslog-ng specfiles/configuration files in order to maintain the specfile readable. Up-to-date sets of specfiles/configuration files: 1) one set for Fedora >= 15 with systemd support, and 2) a second set for EPEL6 with sysV initscripts These two sets are already: 1) using slightly different configure options, (with different build requirements) and 2) different configuration files (e.g. systemd service file vs init script) These differences already make it harder to maintain a single specfile (at least a readable one) for Fedora/EPEL systems. Taking in account other RPM based distros like OpenSUSE will only make it worst. The configuration files are easier to handle: we just need to add them to a packaging/ subdirectory. /jpo PS - As Matthias pointed it out, the git repository of syslog-ng specfiles and configuration files is locate here: http://pkgs.fedoraproject.org/gitweb/?p=syslog-ng.git It contains branches for all Fedora/EPEL relaeses. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=111 --- Comment #5 from Balazs Scheidler <bazsi@balabit.hu> 2011-11-12 13:59:11 --- Thanks for the info. To reiterate then, does it make sense to maintain such a file in the source distribution? I'm quite inclined to remove it then and recommend people to use their distro packages and/or to base their custom packages on their distro spec files. As numerous examples have shown to me, bitrotting stuff in the source tree will bite me in the future. Does anyone has anything against this? -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=111 --- Comment #6 from Matthias Runge <mrunge@fedoraproject.org> 2011-11-14 09:09:40 --- I think it's just consistent to drop .spec (and even systemd) related files. A more convenient solution would be to include some file eg. contact distribution maintainers: fedora/epel: syslog-ng-owner@fedoraproject.org https://admin.fedoraproject.org/pkgdb/acls/bugs/syslog-ng suse: debian: ubuntu: (selection just ramdom, maybe better in alphabetical order) Thoughts? Matthias -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=111 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |algernon@balabit.hu --- Comment #7 from Gergely Nagy <algernon@balabit.hu> 2011-11-14 09:54:45 --- (In reply to comment #6)
I think it's just consistent to drop .spec (and even systemd) related files.
I'd keep the systemd file, at least in the source, even if not installed.
A more convenient solution would be to include some file eg. contact distribution maintainers:
fedora/epel: syslog-ng-owner@fedoraproject.org https://admin.fedoraproject.org/pkgdb/acls/bugs/syslog-ng suse: debian: ubuntu: (selection just ramdom, maybe better in alphabetical order)
I wholeheartedly support this idea! Though, we'll have to figure out the contact addresses for debian/ubuntu (I'd use the same for both), but probably syslog-ng@packages.debian.org + http://bugs.debian.org/syslog-ng would be the right combo. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=111 --- Comment #8 from Balazs Scheidler <bazsi@balabit.hu> 2011-11-14 12:15:34 --- I would really love to have a list like that. In some cases I'd like to Cc maintainers about issues (for instance security stuff). The question is where this would be sensible to do? The tarball may not be visible enough, a page on the website might be. Are those addresses that you mentioned ok to be published on a webpage? -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=111 --- Comment #9 from Matthias Runge <mrunge@fedoraproject.org> 2011-11-14 12:49:36 --- syslog-ng-owner@fedoraproject.org sould reach all maintainers. Currently, I was unable to find this information on any fedoraproject.org page. I don't know about spam protection policy of this address...To reach (any) maintainer in case of security bugs it should suffice. I even can't speak for the other maintainers, I would prefer the web-page to be published. The text may be something like "If you think you've found an error, please file a bug in our bug tracking system". There should be at least some other bug tracking systems for the other distributions. For which people is this contact information useful? those, who are struggling to compile syslog-ng for their own? For those, who installed it via repository? I would probably place all this distribution dependend material under contrib/ (even debian/-dir) -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla＠bugzilla.balabit.com