[Bug 263] New: patterndb: missing "program" attribute in test_message silently ignored
https://bugzilla.balabit.com/show_bug.cgi?id=263 Summary: patterndb: missing "program" attribute in test_message silently ignored Product: syslog-ng Version: 3.5.x Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: unspecified Component: syslog-ng AssignedTo: bazsi@balabit.hu ReportedBy: bugzilla.balabit@faxm0dem.org Type of the Report: --- Estimated Hours: 0.0 Although the attached pdb validates, the test messages are not run, because "program" attribute is missing. There should be a warning, or something: -- pdbtool --validate test /tmp/test2.pdb -dv Module loaded and initialized successfully; module='syslogformat' Module loaded and initialized successfully; module='basicfuncs' /tmp/test2.pdb validates -- -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=263 --- Comment #1 from Fabien Wernli <bugzilla.balabit@faxm0dem.org> 2013-11-27 16:33:10 --- Created an attachment (id=88) --> (https://bugzilla.balabit.com/attachment.cgi?id=88) patterndb ruleset -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=263 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |algernon@balabit.hu AssignedTo|bazsi@balabit.hu |algernon@balabit.hu -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=263 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=263 --- Comment #2 from Gergely Nagy <algernon@balabit.hu> 2013-12-19 11:40:55 --- Hm... Looking at the code, the "$filename validates" comes before running the examples, as that's printed as soon as the patterndb passes an xmllint check. Not having a program attribute is one way to leave a test in place, but disable it, so I wouldn't yell very loudly about it, but I suppose I can make pdbtool emit a warning when it sees something like that, in verbose mode. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=263 --- Comment #3 from Gergely Nagy <algernon@balabit.hu> 2013-12-19 11:52:12 --- I prepared a patch (https://github.com/balabit/syslog-ng/commit/0e68eb8d265481716171c73adbda2dd2...) to address this issue, and submitted a pull request to Bazsi. I plan to add the same change to the 3.5 (and possibly 3.4) branch too. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=263 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution| |FIXED Status|ASSIGNED |RESOLVED --- Comment #4 from Gergely Nagy <algernon@balabit.hu> 2013-12-20 23:32:40 --- This is on both 3.4 and 3.5 master, will be in the next release due in a few days, marking it as fixed. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla＠bugzilla.balabit.com