Re: [syslog-ng] error in syslog-ng 3.2alpha2: missing m4 macros directory
Le 12/10/2010 11:37, Guillaume Rousse a écrit :
Le 06/10/2010 15:40, Balazs Scheidler a écrit :
On Sat, 2010-10-02 at 23:01 +0200, Guillaume Rousse wrote:
Hello.
configure.in has this macro: AC_CONFIG_MACRO_DIR([m4])
However, the m4 directory doesn't exist. As a consequence, running 'autoreconf' fails immediatly. I guess it's just missing, as previous release had it.
Right. I've fixed this in the git tree already. Could you try using a git snapshot? I just tried, the tree still doesn't have any m4 directory... Forget this, I just understood it is dynamically created by autogen.sh script.
[..]
Anyway, I just realized I didn't need to regenerate autotools toolchain, as my patch doesn't impact any relevant file. Here it is, its goal is just to ensure than syslog-ng doesn't create files directly under $localstatedir directory, which is actually /var, but only under its own specific directory, $localstatedir/lib/syslog-ng. It avoid the need to override configure defaults through --localstatedir option, as does the spec file shipped in the tree. Actually, the patch itself only deals with localestatedir, whereas the same issue appears with other shared directories (datadir and sysconfdir).
By default, with a standard prefix, all those locations matches shared directories (/etc, /usr/share, /var), forcing packagers to override all of them to isolate syslog-ng specific content. Having all of them correct by default would be nicer for FHS-addicts. However, it also allow people using a distinct prefix (/opt/syslog-ng for instance) to avoid uselessly long path for different component (/opt/syslog-ng/share instead of /opt/syslog-ng/share/syslog-ng). I guess this is the goal here. -- BOFH excuse #368: Failure to adjust for daylight savings time.
On Tue, 2010-10-12 at 22:53 +0200, Guillaume Rousse wrote:
Le 12/10/2010 11:37, Guillaume Rousse a écrit :
[..]
Anyway, I just realized I didn't need to regenerate autotools toolchain, as my patch doesn't impact any relevant file. Here it is, its goal is just to ensure than syslog-ng doesn't create files directly under $localstatedir directory, which is actually /var, but only under its own specific directory, $localstatedir/lib/syslog-ng. It avoid the need to override configure defaults through --localstatedir option, as does the spec file shipped in the tree. Actually, the patch itself only deals with localestatedir, whereas the same issue appears with other shared directories (datadir and sysconfdir).
By default, with a standard prefix, all those locations matches shared directories (/etc, /usr/share, /var), forcing packagers to override all of them to isolate syslog-ng specific content. Having all of them correct by default would be nicer for FHS-addicts.
However, it also allow people using a distinct prefix (/opt/syslog-ng for instance) to avoid uselessly long path for different component (/opt/syslog-ng/share instead of /opt/syslog-ng/share/syslog-ng). I guess this is the goal here.
yes, exactly. -- Bazsi
participants (2)
-
Balazs Scheidler
-
Guillaume Rousse