[PATCH] [1.9.5] address flex warning and suboptimal distclean target
Hello, The attached patch fixes following two things: 1. #define YY_NO_UNPUT 1 is an undocumented feature of flex and has been obsoleted in recent flex versions. So this is a void operation. The correct way of dealing with the compiler warning is to add %option nounput as flex directive. 2. cfg-lex.c is autogenerated during the make compile process. However it is never removed, especially not for the distclean target. IMHO this is not so clean, so I've added cfg-lex.c to the list of the to-be-removed files. Please consider applying. Cheers, Roberto Nibali, ratz -- echo '[q]sa[ln0=aln256%Pln256/snlbx]sb3135071790101768542287578439snlbxq' | dc
On Thu, 2005-07-28 at 01:15 +0200, Roberto Nibali wrote:
Hello,
The attached patch fixes following two things:
1. #define YY_NO_UNPUT 1 is an undocumented feature of flex and has been obsoleted in recent flex versions. So this is a void operation. The correct way of dealing with the compiler warning is to add %option nounput as flex directive.
2. cfg-lex.c is autogenerated during the make compile process. However it is never removed, especially not for the distclean target. IMHO this is not so clean, so I've added cfg-lex.c to the list of the to-be-removed files.
Thanks. I've applied 1. and changed 2. as it was changing Makefile.in, which is generated by automake. those will be removed only in case of make maintainer-clean as tools are required to rebuild it (e.g. flex), which is not normally needed for compilation. (and the dist also includes it) The snapshot for tomorrow should contain these fixes. -- Bazsi
participants (2)
-
Balazs Scheidler
-
Roberto Nibali