[Bug 30] New: file() on fifo hangs syslog-ng
https://bugzilla.balabit.com/show_bug.cgi?id=30 Summary: file() on fifo hangs syslog-ng Product: syslog-ng Version: 3.0.x Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: unspecified Component: syslog-ng AssignedTo: bazsi@balabit.hu ReportedBy: arekm@maven.pl Type of the Report: enhancement Estimated Hours: 0.0 file() on fifo (made by mkfifo) causes syslog-ng to hang and eat memory. Could some checks be added to prevent such misconfiguration? -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=30 --- Comment #1 from Balazs Scheidler <bazsi@balabit.hu> 2009-02-05 11:19:37 --- sure I could add a check on this, but I couldn't reproduce the ill behaviour in the first place. I tried to use pipes for both source and destination and syslog-ng didn't start eating memory, nor seem stalled. Can you give me more info, like an strace showing the bad behaviour? -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=30 Balazs Scheidler <bazsi@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |FIXED --- Comment #2 from Balazs Scheidler <bazsi@balabit.hu> 2009-02-05 11:27:23 --- and here's the patch for validating file types: commit 8ad0edb1e4198bbf657708d07360bbac8b30b55a Author: Balazs Scheidler <bazsi@balabit.hu> Date: Thu Feb 5 11:26:18 2009 +0100 [affile] validate file type before opening report an error if a file is opened using the pipe() driver, OR a fifo is opened using the file() driver. named pipes should really be driven by the pipe() driver. The validation could even be stricter, but I don't want to close out block/char devices if someone wants to write there, so only the FIFO file type is excluded from using the file driver. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=30 Ben Kibbey <bjk@luxsci.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjk@luxsci.net --- Comment #3 from Ben Kibbey <bjk@luxsci.net> 2009-03-09 23:35:14 --- If the fifo doesn't exist when syslog-ng needs it, syslog-ng will warn repeatedly and CPU goes 100%. Is this the wanted behavior? Maybe only warn once for each fifo? Maybe an option to create the fifo if non-existant? With specified perminssions and user/group access? -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=30 --- Comment #4 from Balazs Scheidler <bazsi@balabit.hu> 2009-03-11 08:23:24 --- (In reply to comment #3)
If the fifo doesn't exist when syslog-ng needs it, syslog-ng will warn repeatedly and CPU goes 100%. Is this the wanted behavior? Maybe only warn once for each fifo? Maybe an option to create the fifo if non-existant? With specified perminssions and user/group access?
as of this patch: commit 5f5d4bd914798c10eef01f6baaf575bc0e3c1557 Author: Balazs Scheidler <bazsi@balabit.hu> Date: Thu Feb 5 11:08:11 2009 +0100 [affile] make it possible to create named pipes As reported on the mailing list, syslog-ng is not currently capable of creating named pipes on its own. This patch will make syslog-ng autocreate pipes when needed. it is possible to create named pipes. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla@bugzilla.balabit.com