[Bug 222] New: systemd unit file should set Restart
https://bugzilla.balabit.com/show_bug.cgi?id=222 Summary: systemd unit file should set Restart Product: syslog-ng Version: 3.4.x Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: unspecified Component: syslog-ng AssignedTo: bazsi@balabit.hu ReportedBy: pdgiddie+balabit@gmail.com Type of the Report: enhancement Estimated Hours: 0.0 To mitigate unforeseen crashes, the systemd unit file should set Restart. This will cause systemd to relaunch the service if it crashes. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=222 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |algernon@balabit.hu AssignedTo|bazsi@balabit.hu |algernon@balabit.hu -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=222 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.4.2 Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=222 --- Comment #1 from Gergely Nagy <algernon@balabit.hu> 2013-02-18 16:19:19 --- On thing I'm unsure about is, what to set Restart= to? I'm contemplating between on-failure and always, and so far, on-failure sounds more appropriate. Do you happen to have a suggestion, perhaps? -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=222 --- Comment #2 from Paul Dann <pdgiddie+balabit@gmail.com> 2013-02-18 16:43:31 --- I don't think there's much in it. I think it comes down to how you want it to behave if root kills it manually. For instance, with Restart=on-failure, root could do "killall syslog-ng" or use an old rc script to stop syslog-ng, and systemd would not restart it (but the unit would be in an error state). With Restart=always, systemd would restart it. I think on-failure probably provides the least surprising behaviour, so I'd go with that. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=222 --- Comment #3 from Paul Dann <pdgiddie+balabit@gmail.com> 2013-02-18 16:47:53 --- Having said that, doing "grep -r Restart= /usr/lib/systemd/system", I see that all use "Restart=always", except for a couple that are set to "no" and "on-abort". So I guess "always" is more popular! Sorry I can't offer any solid guidance :s -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=222 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution| |FIXED Status|ASSIGNED |RESOLVED --- Comment #4 from Gergely Nagy <algernon@balabit.hu> 2013-02-18 16:55:14 --- Well, syslog-ng will be the lonely bird then, at least until someone convinces me that Restart=on-failure is inferior to always. I've added Restart=on-failure to both 3.3 and 3.4, and this change will be in the next releases. Thanks for the suggestion! -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=222 --- Comment #5 from Paul Dann <pdgiddie+balabit@gmail.com> 2013-02-18 16:59:09 --- Great stuff. Thanks for such a quick resolution. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla@bugzilla.balabit.com