Hi, First of all, thanks for your contribution. I was looking forward to this patch, since I had the intention to create a separate syslog-ng-ose-modules repository where I could add 3rd party modules. Please see my comments in-line. Also, please add a "Signed-off-by" line for contributions, and add the patch file in-line to your email, to make it easier to review and comment. I'm trying to integrate your patch anyway and fix issues that I had with it. On Mon, 2011-03-28 at 13:17 +0200, Juhasz Viktor wrote:

Hi!

This patch creates a new package: syslog-ng-dev. Using this you can create your own syslog-ng modules

BR, Viktor Juhasz differences between files attachment (syslog-ng-dev.patch) [syslog-ng-dev] create new package: syslog-ng-dev

this package contains everything which is required to write own module

diff --git a/lib/merge-grammar.pl b/lib/merge-grammar.pl index ab58cd8..305730d 100755 --- a/lib/merge-grammar.pl +++ b/lib/merge-grammar.pl @@ -14,8 +14,9 @@ sub include_block { my ($start_re, $end_re) = @_; + $z = $ENV{'top_srcdir'}. "/lib/cfg-grammar.y";

- open(GR, "<" .$ENV{'top_srcdir'}. "/lib/cfg-grammar.y") || die "Error opening cfg-grammar.y"; + open(GR, "<" .$z) || die "Error opening cfg-grammar.y: ".$z;

my $decl_started = 0; while (<GR>) { @@ -43,4 +44,4 @@ while (<>) { else { print; } -} \ No newline at end of file +}

Hmm.. I'm not sure I completely understand the intention here, and I don't see how an installed copy of cfg-grammar.y will be found. This change only clarifies the error message. Can you show me the code which uses this script?

diff --git a/tgz2build/rules b/tgz2build/rules index ce8ce87..7a34acb 100644 --- a/tgz2build/rules +++ b/tgz2build/rules @@ -1,4 +1,6 @@ #!/usr/bin/make -f +include tgz2build/rules.conf + STAMPDIR=tgz2build/stamps DOCDIR=$(PREFIX)/doc

diff --git a/tgz2build/rules.conf b/tgz2build/rules.conf new file mode 100644 index 0000000..37e8908 --- /dev/null +++ b/tgz2build/rules.conf @@ -0,0 +1,2 @@ +LIBPKGNAME=syslog-ng +DEVPKGNAME=syslog-ng-dev

I don't understand these two hunks, what is rules.conf good for? It defines two variables, but those are completely unused. I've pushed this commit to the 3.3 tree with the questionable hunks omitted (e.g. all the above). If they are deemed to be important or there's an explanation why they should be commited, please post a patch relative to this one. commit ec57eecc9030eb6a4aa1b08f28816a98885308a4 Author: Balazs Scheidler <bazsi@balabit.hu> Date: Mon Mar 28 21:24:07 2011 +0200 add syslog-ng devel package This patch adds a syslog-ng-dev package that contains the syslog-ng headers and related files that makes it possible to build modules outside of the syslog-ng source tree. Signed-off-by: Viktor Juhasz <jviktor@balabit.hu> Signed-off-by: Balazs Scheidler <bazsi@balabit.hu> -- Bazsi