Attached is a new init script I wrote. It's based on the existing init.d.Redhat and init.d.Redhat-7.3 scripts. The main deficiency I wanted to correct was that the existing scripts do not properly implement 'reload' by sending a HUP to the running syslog-ng. Other than that I just tried to clean the init script up and make it consistent with other Redhat-style init scripts. I'm calling this script init.d.Fedora since there were already those existing scripts. However, I believe my script should work on any RedHat or Fedora system, so I would ask that you remove the existing scripts. Unless, of course, there's some functionality I'm missing in my script. Thanks, P. -- Philip J. Hollenback Telemetry Investments phollenback@telemetry-investments.com
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Philip, I also have a patched configuration script and a working specfile for Redhat/Fedora systems. The SRPM is available here: https://bugzilla.fedora.us/show_bug.cgi?id=1332 Regards, jpo | Attached is a new init script I wrote. It's based on the existing | init.d.Redhat and init.d.Redhat-7.3 scripts. The main deficiency I | wanted to correct was that the existing scripts do not properly | implement 'reload' by sending a HUP to the running syslog-ng. Other | than that I just tried to clean the init script up and make it | consistent with other Redhat-style init scripts. | | I'm calling this script init.d.Fedora since there were already those | existing scripts. However, I believe my script should work on any | RedHat or Fedora system, so I would ask that you remove the existing | scripts. | | Unless, of course, there's some functionality I'm missing in my | script. | | Thanks, | P. - -- José Pedro Oliveira Departamento de Informática, Universidade do Minho Tel: +351 253 604470 * Fax: +351 253 604471 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFCA6l0l0metZG9hRsRAtJFAKDWum35MqGNMYU+ROze/t0xDVo5zgCdFDov kbNPVkIpFZwi6gI+aWvFD7U= =FmWM -----END PGP SIGNATURE-----
It looks like we are both tackling the same problems. Actually I wish I had known about your work previously as it would have saved me some time. Anyway, I think the important thing now is to get a new spec file and init script into the syslog-ng source tarball. It looks like this is generated via autoconf so it needs to be converted to syslog-ng.spec.in (just put a couple substitutions in there). My big concern about the existing spec file in the tarball is it is seriously broken. For example, it edits the existing syslog rotate file. Changing another package's file like that is bad. And as far as the init script goes, I think we should put yours in the contrib directory and remove the two existing old and outdated Redhat init scripts. I've reviewed your source rpm and init script, and they incorporate all the fixes I need. Balazs, how does that sound to you? Thanks, P. On 02/04/05, Jose Pedro Oliveira wrote:
Hash: SHA1
Philip,
I also have a patched configuration script and a working specfile for Redhat/Fedora systems.
The SRPM is available here: https://bugzilla.fedora.us/show_bug.cgi?id=1332
Regards, jpo
| Attached is a new init script I wrote. It's based on the existing | init.d.Redhat and init.d.Redhat-7.3 scripts. The main deficiency I | wanted to correct was that the existing scripts do not properly | implement 'reload' by sending a HUP to the running syslog-ng. Other | than that I just tried to clean the init script up and make it | consistent with other Redhat-style init scripts. | | I'm calling this script init.d.Fedora since there were already those | existing scripts. However, I believe my script should work on any | RedHat or Fedora system, so I would ask that you remove the existing | scripts. | | Unless, of course, there's some functionality I'm missing in my | script. | | Thanks, | P.
- -- José Pedro Oliveira Departamento de Informática, Universidade do Minho Tel: +351 253 604470 * Fax: +351 253 604471 Version: GnuPG v1.2.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFCA6l0l0metZG9hRsRAtJFAKDWum35MqGNMYU+ROze/t0xDVo5zgCdFDov kbNPVkIpFZwi6gI+aWvFD7U= =FmWM _______________________________________________ syslog-ng maillist - syslog-ng@lists.balabit.hu https://lists.balabit.hu/mailman/listinfo/syslog-ng Frequently asked questions at http://www.campin.net/syslog-ng/faq.html
-- Philip J. Hollenback Telemetry Investments phollenback@telemetry-investments.com
There is really only three choices here: [1] Edit the existing file which belongs to another package, but a package that serves the same function as this one. [2] You replace the file which is still affecting an existing package, but you would lose any custom changes in the file. [3] You create a new file which will most likely have duplicates with the old package which will cause other difficulties. Of these I think ti would be better to edit the existing file to not lose any custom entries that may have been made, and it has the least impact on the existing packages. Richard Philip J. Hollenback wrote:
It looks like we are both tackling the same problems. Actually I wish I had known about your work previously as it would have saved me some time.
Anyway, I think the important thing now is to get a new spec file and init script into the syslog-ng source tarball. It looks like this is generated via autoconf so it needs to be converted to syslog-ng.spec.in (just put a couple substitutions in there).
My big concern about the existing spec file in the tarball is it is seriously broken. For example, it edits the existing syslog rotate file. Changing another package's file like that is bad.
And as far as the init script goes, I think we should put yours in the contrib directory and remove the two existing old and outdated Redhat init scripts.
I've reviewed your source rpm and init script, and they incorporate all the fixes I need.
Balazs, how does that sound to you?
Thanks, P.
On 02/04/05, Jose Pedro Oliveira wrote:
Hash: SHA1
Philip,
I also have a patched configuration script and a working specfile for Redhat/Fedora systems.
The SRPM is available here: https://bugzilla.fedora.us/show_bug.cgi?id=1332
Regards, jpo
| Attached is a new init script I wrote. It's based on the existing | init.d.Redhat and init.d.Redhat-7.3 scripts. The main deficiency I | wanted to correct was that the existing scripts do not properly | implement 'reload' by sending a HUP to the running syslog-ng. Other | than that I just tried to clean the init script up and make it | consistent with other Redhat-style init scripts. | | I'm calling this script init.d.Fedora since there were already those | existing scripts. However, I believe my script should work on any | RedHat or Fedora system, so I would ask that you remove the existing | scripts. | | Unless, of course, there's some functionality I'm missing in my | script. | | Thanks, | P.
- -- José Pedro Oliveira Departamento de Informática, Universidade do Minho Tel: +351 253 604470 * Fax: +351 253 604471 Version: GnuPG v1.2.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFCA6l0l0metZG9hRsRAtJFAKDWum35MqGNMYU+ROze/t0xDVo5zgCdFDov kbNPVkIpFZwi6gI+aWvFD7U= =FmWM _______________________________________________ syslog-ng maillist - syslog-ng@lists.balabit.hu https://lists.balabit.hu/mailman/listinfo/syslog-ng Frequently asked questions at http://www.campin.net/syslog-ng/faq.html
Well, even though syslog and syslog-ng accomplish the same task, they are separate entities. You could run both of them on your system if you wanted to. I don't think you should replace a file that another package uses, so I think #3 is the only good answer. P. On 02/04/05, Richard E. Perlotto II wrote:
There is really only three choices here:
[1] Edit the existing file which belongs to another package, but a package that serves the same function as this one. [2] You replace the file which is still affecting an existing package, but you would lose any custom changes in the file. [3] You create a new file which will most likely have duplicates with the old package which will cause other difficulties.
Of these I think ti would be better to edit the existing file to not lose any custom entries that may have been made, and it has the least impact on the existing packages.
Richard
Philip J. Hollenback wrote:
It looks like we are both tackling the same problems. Actually I wish I had known about your work previously as it would have saved me some time.
Anyway, I think the important thing now is to get a new spec file and init script into the syslog-ng source tarball. It looks like this is generated via autoconf so it needs to be converted to syslog-ng.spec.in (just put a couple substitutions in there).
My big concern about the existing spec file in the tarball is it is seriously broken. For example, it edits the existing syslog rotate file. Changing another package's file like that is bad.
And as far as the init script goes, I think we should put yours in the contrib directory and remove the two existing old and outdated Redhat init scripts.
I've reviewed your source rpm and init script, and they incorporate all the fixes I need.
Balazs, how does that sound to you?
Thanks, P.
On 02/04/05, Jose Pedro Oliveira wrote:
Hash: SHA1
Philip,
I also have a patched configuration script and a working specfile for Redhat/Fedora systems.
The SRPM is available here: https://bugzilla.fedora.us/show_bug.cgi?id=1332
Regards, jpo
| Attached is a new init script I wrote. It's based on the existing | init.d.Redhat and init.d.Redhat-7.3 scripts. The main deficiency I | wanted to correct was that the existing scripts do not properly | implement 'reload' by sending a HUP to the running syslog-ng. Other | than that I just tried to clean the init script up and make it | consistent with other Redhat-style init scripts. | | I'm calling this script init.d.Fedora since there were already those | existing scripts. However, I believe my script should work on any | RedHat or Fedora system, so I would ask that you remove the existing | scripts. | | Unless, of course, there's some functionality I'm missing in my | script. | | Thanks, | P.
- -- José Pedro Oliveira Departamento de Informática, Universidade do Minho Tel: +351 253 604470 * Fax: +351 253 604471 Version: GnuPG v1.2.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFCA6l0l0metZG9hRsRAtJFAKDWum35MqGNMYU+ROze/t0xDVo5zgCdFDov kbNPVkIpFZwi6gI+aWvFD7U= =FmWM _______________________________________________ syslog-ng maillist - syslog-ng@lists.balabit.hu https://lists.balabit.hu/mailman/listinfo/syslog-ng Frequently asked questions at http://www.campin.net/syslog-ng/faq.html
_______________________________________________ syslog-ng maillist - syslog-ng@lists.balabit.hu https://lists.balabit.hu/mailman/listinfo/syslog-ng Frequently asked questions at http://www.campin.net/syslog-ng/faq.html
-- Philip J. Hollenback Telemetry Investments phollenback@telemetry-investments.com
And then you would have two logrotate files for many of the same files. This is a worse situation. Since syslog many times is considered a base OS package it cannot be removed. This means a lot of manual modification to clean out BOTH files so that they are not stepping on each other. Kind of defeats the purpose of having a package install. Richard Philip J. Hollenback wrote:
Well, even though syslog and syslog-ng accomplish the same task, they are separate entities. You could run both of them on your system if you wanted to. I don't think you should replace a file that another package uses, so I think #3 is the only good answer.
P.
On 02/04/05, Richard E. Perlotto II wrote:
There is really only three choices here:
[1] Edit the existing file which belongs to another package, but a package that serves the same function as this one. [2] You replace the file which is still affecting an existing package, but you would lose any custom changes in the file. [3] You create a new file which will most likely have duplicates with the old package which will cause other difficulties.
Of these I think ti would be better to edit the existing file to not lose any custom entries that may have been made, and it has the least impact on the existing packages.
Richard
Philip J. Hollenback wrote:
It looks like we are both tackling the same problems. Actually I wish I had known about your work previously as it would have saved me some time.
Anyway, I think the important thing now is to get a new spec file and init script into the syslog-ng source tarball. It looks like this is generated via autoconf so it needs to be converted to syslog-ng.spec.in (just put a couple substitutions in there).
My big concern about the existing spec file in the tarball is it is seriously broken. For example, it edits the existing syslog rotate file. Changing another package's file like that is bad.
And as far as the init script goes, I think we should put yours in the contrib directory and remove the two existing old and outdated Redhat init scripts.
I've reviewed your source rpm and init script, and they incorporate all the fixes I need.
Balazs, how does that sound to you?
Thanks, P.
On 02/04/05, Jose Pedro Oliveira wrote:
Hash: SHA1
Philip,
I also have a patched configuration script and a working specfile for Redhat/Fedora systems.
The SRPM is available here: https://bugzilla.fedora.us/show_bug.cgi?id=1332
Regards, jpo
| Attached is a new init script I wrote. It's based on the existing | init.d.Redhat and init.d.Redhat-7.3 scripts. The main deficiency I | wanted to correct was that the existing scripts do not properly | implement 'reload' by sending a HUP to the running syslog-ng. Other | than that I just tried to clean the init script up and make it | consistent with other Redhat-style init scripts. | | I'm calling this script init.d.Fedora since there were already those | existing scripts. However, I believe my script should work on any | RedHat or Fedora system, so I would ask that you remove the existing | scripts. | | Unless, of course, there's some functionality I'm missing in my | script. | | Thanks, | P.
- -- José Pedro Oliveira Departamento de Informática, Universidade do Minho Tel: +351 253 604470 * Fax: +351 253 604471 Version: GnuPG v1.2.6 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFCA6l0l0metZG9hRsRAtJFAKDWum35MqGNMYU+ROze/t0xDVo5zgCdFDov kbNPVkIpFZwi6gI+aWvFD7U= =FmWM _______________________________________________ syslog-ng maillist - syslog-ng@lists.balabit.hu https://lists.balabit.hu/mailman/listinfo/syslog-ng Frequently asked questions at http://www.campin.net/syslog-ng/faq.html
_______________________________________________ syslog-ng maillist - syslog-ng@lists.balabit.hu https://lists.balabit.hu/mailman/listinfo/syslog-ng Frequently asked questions at http://www.campin.net/syslog-ng/faq.html
* Richard E. Perlotto II <rperlott@cisco.com>
This means a lot of manual modification to clean out BOTH files so that they are not stepping on each other. Kind of defeats the purpose of having a package install.
My custom syslog-ng RPM provides a generic client configuration for the site (local logs + relay to central loghost); other needs (proxy and loghost configuration, disabling logrotate for the stock syslog package) are implemented via CFEngine.
On Fri, Feb 04, 2005 at 01:48:59PM -0800, Richard E. Perlotto II wrote:
And then you would have two logrotate files for many of the same files. This is a worse situation. Since syslog many times is considered a base OS package it cannot be removed.
It can be removed no problem if there's another package that provides 'syslog' (or sysklogd not sure). This could be done in the syslog-ng spec file. -- Wolfgang Braun, Dipl.-Inform. (FH) <wolfgang.braun@gmx.de> gpg-key: 1024D/4B32CE55 gpg-fingerprint: 7F0F DE82 94A5 B476 0E08 4972 AC95 31A3 4B32 CE55
Wolfgang Braun wrote:
On Fri, Feb 04, 2005 at 01:48:59PM -0800, Richard E. Perlotto II wrote:
And then you would have two logrotate files for many of the same files. This is a worse situation. Since syslog many times is considered a base OS package it cannot be removed.
It can be removed no problem if there's another package that provides 'syslog' (or sysklogd not sure). This could be done in the syslog-ng spec file.
The SRPM I submitted for QA in Fedora.us already has a Provides statement: "Provides: sysklogd = 0:1.4.1-99" Right now, the only problem I am having, is how to improve the handling of the syslog/syslog-ng logrotate file: it only works if there are no sysklogd upgrades (no problems if sysklogd is removed). As Enrico suggested in comment 23, a possible solution may reside in the usage of %trigger scripts. All possible solutions/comments are welcome (even better if they are submitted via bugzilla). References: * Fedora.us syslog-ng QA comments https://bugzilla.fedora.us/show_bug.cgi?id=1332 This package aims to be a replacement of RedHat/Fedora sysklogd (tries to follow the same logging rules). * Packaging software with RPM, Part 3 Running scripts at install and uninstall http://www-106.ibm.com/developerworks/library/l-rpm3.html Regards, jpo -- José Pedro Oliveira * mailto: jpo@di.uminho.pt * http://gsd.di.uminho.pt/~jpo * * gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *
On Fri, 2005-02-04 at 13:45 -0500, Philip J. Hollenback wrote:
It looks like we are both tackling the same problems. Actually I wish I had known about your work previously as it would have saved me some time.
Anyway, I think the important thing now is to get a new spec file and init script into the syslog-ng source tarball. It looks like this is generated via autoconf so it needs to be converted to syslog-ng.spec.in (just put a couple substitutions in there).
My big concern about the existing spec file in the tarball is it is seriously broken. For example, it edits the existing syslog rotate file. Changing another package's file like that is bad.
And as far as the init script goes, I think we should put yours in the contrib directory and remove the two existing old and outdated Redhat init scripts.
I've reviewed your source rpm and init script, and they incorporate all the fixes I need.
Sounds fine, can you send me the exact files I should add and where? I'm not that good at RPM packaging. -- Bazsi
Balazs,
On Fri, 2005-02-04 at 13:45 -0500, Philip J. Hollenback wrote:
It looks like we are both tackling the same problems. Actually I wish I had known about your work previously as it would have saved me some time.
Anyway, I think the important thing now is to get a new spec file and init script into the syslog-ng source tarball. It looks like this is generated via autoconf so it needs to be converted to syslog-ng.spec.in (just put a couple substitutions in there).
My big concern about the existing spec file in the tarball is it is seriously broken. For example, it edits the existing syslog rotate file. Changing another package's file like that is bad.
And as far as the init script goes, I think we should put yours in the contrib directory and remove the two existing old and outdated Redhat init scripts.
I've reviewed your source rpm and init script, and they incorporate all the fixes I need.
Sounds fine, can you send me the exact files I should add and where? I'm not that good at RPM packaging.
If you agree, I will send you the following files: * a libol specfile patch (minor update) * four files for the syslog-ng contrib directory fedora.init fedora.conf fedora.sysconfig fedora.logrotate * syslog-ng specfile Regards, jpo -- José Pedro Oliveira * mailto: jpo@di.uminho.pt * http://gsd.di.uminho.pt/~jpo * * gpg fingerprint = F9B6 8D87 859D 1C94 48F0 84C0 9749 9EB5 91BD 851B *
On Mon, 2005-02-07 at 16:53 +0000, José Pedro Oliveira wrote:
Balazs,
On Fri, 2005-02-04 at 13:45 -0500, Philip J. Hollenback wrote:
It looks like we are both tackling the same problems. Actually I wish I had known about your work previously as it would have saved me some time.
Anyway, I think the important thing now is to get a new spec file and init script into the syslog-ng source tarball. It looks like this is generated via autoconf so it needs to be converted to syslog-ng.spec.in (just put a couple substitutions in there).
My big concern about the existing spec file in the tarball is it is seriously broken. For example, it edits the existing syslog rotate file. Changing another package's file like that is bad.
And as far as the init script goes, I think we should put yours in the contrib directory and remove the two existing old and outdated Redhat init scripts.
I've reviewed your source rpm and init script, and they incorporate all the fixes I need.
Sounds fine, can you send me the exact files I should add and where? I'm not that good at RPM packaging.
If you agree, I will send you the following files:
* a libol specfile patch (minor update) * four files for the syslog-ng contrib directory fedora.init fedora.conf fedora.sysconfig fedora.logrotate * syslog-ng specfile
I'm certainly willing to update the specfiles however I'd be happier if Richard and you could work on an mutual agreement on how to handle logrotate files. -- Bazsi
participants (7)
-
Balazs Scheidler
-
Jeremy Mates
-
Jose Pedro Oliveira
-
José Pedro Oliveira
-
Philip J. Hollenback
-
Richard E. Perlotto II
-
Wolfgang Braun