[Bug 86] New: flush_timeout has no effect
https://bugzilla.balabit.com/show_bug.cgi?id=86 Summary: flush_timeout has no effect Product: syslog-ng Version: 3.0.x Platform: PC OS/Version: Linux Status: NEW Severity: major Priority: unspecified Component: syslog-ng AssignedTo: bazsi@balabit.hu ReportedBy: erempel@uvic.ca Type of the Report: --- Estimated Hours: 0.0 After upgrading to version 3.0.7 OSE the flush_timeout option has no effect for file destinations. The messages are buffered until flush_lines is reached and then they are flushed. TCP destinations are no affected by this issue. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=86 Balazs Scheidler <bazsi@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical Resolution| |FIXED Status|NEW |RESOLVED --- Comment #1 from Balazs Scheidler <bazsi@balabit.hu> 2010-06-21 20:08:55 --- Right, I didn't check file destinations, which is somewhat an exception. Sorry for that, and thanks for the report: Here's the patch: commit 8c87164ac40257aceaba37ebbc4987c7868ac251 Author: Balazs Scheidler <bazsi@balabit.hu> Date: Mon Jun 21 20:04:59 2010 +0200 affile: fixed flush_timeout() processing for destination files The patch "logwriter: fixed flush_timeout handling on non-file destinations" broke flush_timeout() processing for file destination, this patch fixes that. Since this is a serious issue, I'm going to release 3.0.8 However before I'd do that, I would appreciate some testing. I wouldn't want to make the same mistake again. My automated tests do not cover this area. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=86 --- Comment #2 from Evan Rempel <erempel@uvic.ca> 2010-06-29 19:38:21 ---
Right, I didn't check file destinations, which is somewhat an exception. Sorry for that, and thanks for the report:
Here's the patch:
commit 8c87164ac40257aceaba37ebbc4987c7868ac251 Author: Balazs Scheidler <bazsi@balabit.hu> Date: Mon Jun 21 20:04:59 2010 +0200
affile: fixed flush_timeout() processing for destination files
The patch "logwriter: fixed flush_timeout handling on non-file destinations" broke flush_timeout() processing for file destination, this patch fixes that.
OK, I can test this, but "where is the patch?" -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=86 --- Comment #3 from Balazs Scheidler <bazsi@balabit.hu> 2010-06-30 17:45:55 --- (In reply to comment #2)
Right, I didn't check file destinations, which is somewhat an exception. Sorry for that, and thanks for the report:
Here's the patch:
commit 8c87164ac40257aceaba37ebbc4987c7868ac251 Author: Balazs Scheidler <bazsi@balabit.hu> Date: Mon Jun 21 20:04:59 2010 +0200
affile: fixed flush_timeout() processing for destination files
The patch "logwriter: fixed flush_timeout handling on non-file destinations" broke flush_timeout() processing for file destination, this patch fixes that.
OK, I can test this, but "where is the patch?"
sorry, it is in the git archive, and the listing above is the git patch ID. attaching a diff file to this ticket. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=86 --- Comment #4 from Balazs Scheidler <bazsi@balabit.hu> 2010-06-30 17:46:26 --- Created an attachment (id=21) --> (https://bugzilla.balabit.com/attachment.cgi?id=21) patch to fix the problem -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=86 --- Comment #5 from Evan Rempel <erempel@uvic.ca> 2010-06-30 19:26:27 --- Installed and seems to solve the flush_timeout issue. I will monitor for a couple of days for buffering etc. and report back. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=86 --- Comment #6 from Evan Rempel <erempel@uvic.ca> 2010-07-02 17:42:12 --- This latest patch looks like it has not introduced any new issues. I am comfortable moving this (and have actually done so) into our production release at our organization. Well done. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=86 --- Comment #7 from Balazs Scheidler <bazsi@balabit.hu> 2010-07-09 09:27:10 --- Thanks, will release 3.0.8 shortly. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla＠bugzilla.balabit.com