Hello, There are a couple of problem with smtp support. Tested on openSUSE and FreeBSD. Neither have libesmtp installed, at least not as default. So configure is right: SMTP support (module) : no On the other hand: - libafsmtp is built and installed - unlike the others, it is installed as a versioned library: linux-v3g3:~ # ls -l /lib/syslog-ng/ total 556 -rwxr-xr-x 1 root root 73212 Mar 21 09:14 libaffile.so -rwxr-xr-x 1 root root 48567 Mar 21 09:14 libafprog.so lrwxrwxrwx 1 root root 18 Mar 21 09:18 libafsmtp.so -> libafsmtp.so.0.0.0 lrwxrwxrwx 1 root root 18 Mar 21 09:18 libafsmtp.so.0 -> libafsmtp.so.0.0.0 -rwxr-xr-x 1 root root 6445 Mar 21 09:14 libafsmtp.so.0.0.0 -rwxr-xr-x 1 root root 118106 Mar 21 09:14 libafsocket.so -rwxr-xr-x 1 root root 34040 Mar 21 09:14 libafuser.so -rwxr-xr-x 1 root root 23092 Mar 21 09:14 libbasicfuncs.so -rwxr-xr-x 1 root root 11819 Mar 21 09:14 libconfgen.so -rwxr-xr-x 1 root root 38464 Mar 21 09:14 libcsvparser.so -rwxr-xr-x 1 root root 105045 Mar 21 09:14 libdbparser.so -rwxr-xr-x 1 root root 33668 Mar 21 09:14 libdummy.so -rwxr-xr-x 1 root root 21134 Mar 21 09:14 libsyslogformat.so -rwxr-xr-x 1 root root 28448 Mar 21 09:14 libsyslog-ng-crypto.so -rwxr-xr-x 1 root root 7339 Mar 21 09:14 libtfuuid.so ToDo: - option to disable smtp support - do not build/install it if build dependency is unavailable - do not install it as a versioned library Bye, -- Peter Czanik (CzP)<czanik@balabit.hu> BalaBit IT Security / syslog-ng upstream http://czanik.blogs.balabit.com/
Peter Czanik <czanik@balabit.hu> writes:
Hello,
There are a couple of problem with smtp support. Tested on openSUSE and FreeBSD. Neither have libesmtp installed, at least not as default. So configure is right:
SMTP support (module) : no
On the other hand:
- libafsmtp is built and installed
- unlike the others, it is installed as a versioned library:
Both of these problems stem from the very same issue, which is also present in afmongodb too: even if they're disabled, the Makefile.am still has module_LTLIBRARIES set, and in that case, it doesn't set the LDFLAGS, so -avoid-version doesn't get passed, and so on and so forth. The correct fix here is to move the module_LTLIBRARIES line inside the if ENABLE_SMTP block. A patch doing that will soon follow.
- option to disable smtp support
Oh, right. I forgot this one. The logic is present in configure.in, but I forgot the --enable-smtp (& --disable-smtp) option. Sorry!
- do not build/install it if build dependency is unavailable
Patch incoming.
- do not install it as a versioned library
The patch for the above fixes this, as when the SMTP module is enabled, it is correctly installed without a version. The bug only happens when it's disabled. -- |8]
participants (2)
-
Gergely Nagy
-
Peter Czanik