[Bug 101] New: Typo in modules/afsocket/Makefile.am
https://bugzilla.balabit.com/show_bug.cgi?id=101 Summary: Typo in modules/afsocket/Makefile.am Product: syslog-ng Version: 3.2.x Platform: PC OS/Version: All Status: NEW Severity: normal Priority: unspecified Component: syslog-ng AssignedTo: bazsi@balabit.hu ReportedBy: vinschen@redhat.com Type of the Report: --- Estimated Hours: 0.0 Created an attachment (id=27) --> (https://bugzilla.balabit.com/attachment.cgi?id=27) Patch to fix issue "Typo in modules/afsocket/Makefile.am" Usually $DESTDIR is used without a trailing slash, for instance: $(DESTDIR)$(prefix) In modules/afsocket/Makefile.am, it's erroneously used with a trailing slash in the rules creating the libafsocket.so symlink: $(DESTDIR)/$(moduledir) Assuming $(DESTDIR) is empty, this may result in an erroneous double slash at the beginning of the resulting path: moduledir=/usr/lib/syslog-ng ==> $(DESTDIR)/$(moduledir) == //usr/lib/syslog-ng Per POSIX, a double slash at the start of the path is allowed to have a system-dependent meaning, so this shouldn't happen. I've attached a patch to fix this issue. Corinna -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=101 Balazs Scheidler <bazsi@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution| |FIXED Status|NEW |RESOLVED --- Comment #1 from Balazs Scheidler <bazsi@balabit.hu> 2010-12-08 21:36:20 --- Thanks for your contribution. I've applied your patch here: commit 40c067135982c2f0ae66dcffee7498ed57e44882 Author: Balazs Scheidler <bazsi@balabit.hu> Date: Wed Dec 8 21:35:29 2010 +0100 afsocket: fixed Makefile rules to avoid using double slash at the beginning of a filename Issue reported by and fix proposed by Corinna Vinschen to make it possible to compile syslog-ng on cygwin. Reported-By: Corinna Vinschen Signed-off-by: Balazs Scheidler <bazsi@balabit.hu> -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla@bugzilla.balabit.com