Thank you for such a quick turn-around on this issue. I've run into a couple more. 1) New files are being created with file permissions equal to the inverse of umask, entirely ignoring the permissions specified in the perm() option. Hardcoding the permissions in the open() call in affile.c fixes the problem (yes, I know it's not the way to do it, but I was in a hurry). In other words, it appears that the value of mode is all ones rather than whatever was specified in the perm() option. 2) Syslog-ng does not appear to be closing the log files and maintains a lock on the files until the application exits. This one is causing me no end of grief. Thanks again, ZB -----Original Message----- From: syslog-ng-bounces@lists.balabit.hu [mailto:syslog-ng-bounces@lists.balabit.hu] On Behalf Of Balazs Scheidler Sent: Friday, June 24, 2005 1:56 AM To: Syslog-ng users' and developers' mailing list Subject: Re: [syslog-ng] Error parsing conf file? On Thu, 2005-06-23 at 14:42 -0600, Zb Indelak wrote:
I have been running syslog-ng 1.6.5 on a bunch of my systems for a while, however since I'm centralizing the logs from multiple time zones, I decided to upgrade to version 1.9.4 so that I could use the rcvd_time_zone () option. After installing version 1.9.4 I can no longer read the syslog-ng.conf file that worked fine with version 1.6.5.
Version 1.9.4 gives the error "syntax error at 23" Version 1.9.4+20050623 gives the error "syntax error at 19"
Committed this patch, it makes syslog-ng read your configuration file fine: --- orig/src/cfg-lex.l +++ mod/src/cfg-lex.l @@ -70,6 +70,7 @@ static struct keyword keywords[] = { { "pad_size", KW_PAD_SIZE }, { "mark_freq", KW_MARK_FREQ }, { "sync_freq", KW_SYNC_FREQ }, + { "sync", KW_SYNC_FREQ }, { "fsync", KW_FSYNC }, { "long_hostnames", KW_CHAIN_HOSTNAMES }, { "chain_hostnames", KW_CHAIN_HOSTNAMES }, Should be available in tomorrow's snapshot. -- Bazsi _______________________________________________ syslog-ng maillist - syslog-ng@lists.balabit.hu https://lists.balabit.hu/mailman/listinfo/syslog-ng Frequently asked questions at http://www.campin.net/syslog-ng/faq.html
{ "sync_freq", KW_SYNC_FREQ }, + { "sync", KW_SYNC_FREQ }, { "fsync", KW_FSYNC },
OK.. So I *was* caffeine-challenged at the time... ;)
On Fri, 2005-06-24 at 09:15 -0600, Zb Indelak wrote:
Thank you for such a quick turn-around on this issue. I've run into a couple more.
1) New files are being created with file permissions equal to the inverse of umask, entirely ignoring the permissions specified in the perm() option. Hardcoding the permissions in the open() call in affile.c fixes the problem (yes, I know it's not the way to do it, but I was in a hurry). In other words, it appears that the value of mode is all ones rather than whatever was specified in the perm() option.
this one is fixed, committed, the next snapshot should contain the fix.
2) Syslog-ng does not appear to be closing the log files and maintains a lock on the files until the application exits. This one is causing me no end of grief.
I don't really know what you mean here? syslog-ng does not lock files on its own and according to my tests dynamic output files were properly reaped (closed in time as time_reap() specifies) non-dynamic files (which has no macros in the name) are not reaped, but IIRC syslog-ng 1.6.x did not reap those either. -- Bazsi
participants (3)
-
Balazs Scheidler
-
Valdis.Kletnieks＠vt.edu
-
Zb Indelak