[Bug 201] New: system() does not work on FreeBSD: /dev/ klog is pretty much ignored
https://bugzilla.balabit.com/show_bug.cgi?id=201 Summary: system() does not work on FreeBSD: /dev/klog is pretty much ignored Product: syslog-ng Version: 3.3.x Platform: All OS/Version: FreeBSD Status: ASSIGNED Severity: normal Priority: unspecified Component: syslog-ng AssignedTo: algernon@balabit.hu ReportedBy: algernon@balabit.hu Type of the Report: --- Estimated Hours: 0.0 While debugging another problem, I found a couple of issues with system() on FreeBSD: * follow-freq(0) doesn't appear to work, so /dev/klog gets ignored outright * Even with follow-freq(1), we never read from /dev/klog, because stat() will report its size to be 0, so we never end up reading from it. The second is easy to fix, adding an || !S_ISREG(st.st_mode) to the appropriate condition in log_reader_io_follow_file() does the right thing. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=201 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.3.7 -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=201 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution| |FIXED Status|ASSIGNED |RESOLVED --- Comment #1 from Gergely Nagy <algernon@balabit.hu> 2012-10-08 11:08:54 --- Updating ivykis to 0.30.4, and with the || !S_ISREG(st.st_mode) change, /dev/klog works correctly. Marking as fixed. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=201 Balazs Scheidler <bazsi@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bazsi@balabit.hu --- Comment #2 from Balazs Scheidler <bazsi@balabit.hu> 2012-10-13 10:14:35 --- I'd rather introduce the device() source we were discussing, perhaps even pushing the "readable" check in LogReader to LogTransport instances. The S_ISREG check shouldn't be required now, if someone is using the system() source (which explicitly uses follow-freq(0)), or the file driver straight as it has a special case for /dev/klog to make follow-freq(0) by default. The root cause for this bug was in ivykis. That said, the fix can stay in place, I'll merge that to 3.4, however I think it should go away once the LogTransport refactoring happens. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=201 --- Comment #3 from Gergely Nagy <algernon@balabit.hu> 2012-10-13 10:26:32 --- (In reply to comment #2)
That said, the fix can stay in place, I'll merge that to 3.4, however I think it should go away once the LogTransport refactoring happens.
Completely agreed. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla＠bugzilla.balabit.com