[Bug 213] New: Build Failure on AIX with syslog-ng-3.3.6 and gcc 4.2.0
https://bugzilla.balabit.com/show_bug.cgi?id=213 Summary: Build Failure on AIX with syslog-ng-3.3.6 and gcc 4.2.0 Product: syslog-ng Version: 3.3.x Platform: PC OS/Version: AIX Status: NEW Severity: normal Priority: unspecified Component: syslog-ng AssignedTo: bazsi@balabit.hu ReportedBy: blentz@cswg.com Type of the Report: --- Estimated Hours: 0.0 /bin/sh ../libtool --tag=CC --mode=compile gcc -g -Wl,-blibpath:/opt/local/syslog-ng/lib:/usr/lib:/lib,-brtl -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I/opt/local/syslog-ng/include -pthread -I/opt/local/syslog-ng/include/glib-2.0 -I/opt/local/syslog-ng/lib/glib-2.0/include -I/opt/local/syslog-ng/include/eventlog -I/opt/local/syslog-ng/include -I/opt/local/syslog-ng/include -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/opt/local/syslog-ng/include -Wall -pthread -D_LARGE_FILES=1 -MT mainloop.lo -MD -MP -MF .deps/mainloop.Tpo -c -o mainloop.lo mainloop.c libtool: compile: gcc -g -Wl,-blibpath:/opt/local/syslog-ng/lib:/usr/lib:/lib,-brtl -std=gnu99 -DHAVE_CONFIG_H -I. -I.. -I/opt/local/syslog-ng/include -pthread -I/opt/local/syslog-ng/include/glib-2.0 -I/opt/local/syslog-ng/lib/glib-2.0/include -I/opt/local/syslog-ng/include/eventlog -I/opt/local/syslog-ng/include -I/opt/local/syslog-ng/include -D_GNU_SOURCE -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/opt/local/syslog-ng/include -Wall -pthread -D_LARGE_FILES=1 -MT mainloop.lo -MD -MP -MF .deps/mainloop.Tpo -c mainloop.c -DPIC -o .libs/mainloop.o mainloop.c: In function 'main_loop_call': mainloop.c:177: warning: implicit declaration of function 'iv_event_post' mainloop.c: In function 'main_loop_call_init': mainloop.c:217: warning: implicit declaration of function 'IV_EVENT_INIT' mainloop.c:218: error: invalid use of undefined type 'struct iv_event' mainloop.c:219: error: invalid use of undefined type 'struct iv_event' mainloop.c:220: warning: implicit declaration of function 'iv_event_register' make[4]: *** [mainloop.lo] Error 1 make[4]: Leaving directory `/home/blentz/build/syslog-ng-3.3.6/lib' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/home/blentz/build/syslog-ng-3.3.6/lib' make[2]: *** [all] Error 2 make[2]: Leaving directory `/home/blentz/build/syslog-ng-3.3.6/lib' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/blentz/build/syslog-ng-3.3.6' make: *** [all] Error 2 Making install in lib -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=213 --- Comment #1 from Ben Lentz <blentz@cswg.com> 2012-12-19 21:42:55 --- Note that version 3.2.5 builds fine. Note that version 3.3.7 has the same problem as 3.3.6, except that 3.3.7 also has a build error in ./lib/cfg-lexer.c r = glob(pattern, GLOB_NOMAGIC, _cfg_lexer_glob_err, &globbuf); to: r = glob(pattern, GLOB_NOCHECK, _cfg_lexer_glob_err, &globbuf); -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=213 --- Comment #2 from Ben Lentz <blentz@cswg.com> 2012-12-19 22:20:12 --- Patches required to get 3.3.7 *** lib/cfg-lexer.c Wed Dec 19 15:54:34 2012 --- lib/cfg-lexer.c Wed Dec 19 15:54:44 2012 *************** *** 497,503 **** int r; CfgIncludeLevel *level; ! r = glob(pattern, GLOB_NOMAGIC, _cfg_lexer_glob_err, &globbuf); if (r != 0) { --- 497,503 ---- int r; CfgIncludeLevel *level; ! r = glob(pattern, GLOB_NOCHECK, _cfg_lexer_glob_err, &globbuf); if (r != 0) { *** lib/mainloop.c Wed Dec 19 15:55:17 2012 --- lib/mainloop.c Wed Dec 19 15:55:29 2012 *************** *** 43,48 **** --- 43,49 ---- #include <iv.h> #include <iv_signal.h> #include <iv_work.h> + #include <iv_event.h> /** * Processing model -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=213 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |3.3.8 CC| |algernon@balabit.hu AssignedTo|bazsi@balabit.hu |algernon@balabit.hu --- Comment #3 from Gergely Nagy <algernon@balabit.hu> 2012-12-20 13:02:57 --- Thanks for the report and the patch, I will apply this to 3.3's git head shortly, with some minor modifications: I don't want to replace GLOB_NOMAGIC with GLOB_NOCHECK, as they're not the same. With GLOB_NOMAGIC, "/etc/syslog-ng/foo.conf" both would return foo.conf, but for "/etc/syslog-ng/conf.d/*.conf", NOCHECK would return the pattern, NOMAGIC would return GLOB_NOMATCH. So on platforms that do have NOMAGIC, syslog-ng should use it, on others, it should fall back to NOCHECK as the next best option. I plan to do this with something along these lines: #ifndef GLOB_NOMAGIC #define GLOB_NOMAGIC GLOB_NOCHECK #endif Or better yet, implement NOMAGIC if the platform does not support it. I'll see which option is more feasible in our case. -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=213 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
https://bugzilla.balabit.com/show_bug.cgi?id=213 Gergely Nagy <algernon@balabit.hu> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution| |FIXED Status|ASSIGNED |RESOLVED --- Comment #4 from Gergely Nagy <algernon@balabit.hu> 2012-12-20 14:12:49 --- (In reply to comment #3)
Or better yet, implement NOMAGIC if the platform does not support it. I'll see which option is more feasible in our case.
This is what I ended up doing, as the code required was pretty simple. I pushed the fix for both the iv_event.h include and the GLOB_NOMAGIC implementation to 3.3's master, both will be part of syslog-ng 3.3.8. Thanks for the report! -- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla＠bugzilla.balabit.com