Hi, Thanks for reporting these. On Sun, 2011-10-23 at 00:00 +0100, Jose Pedro Oliveira wrote:
Balazs Scheidler,
On 2011-10-22 07:10, Balazs Scheidler wrote:
Hi,
I wanted to publish a last maintenance release from the 3.2 branch before moving on to work on 3.4.
I've backported the relevant patches, tests have ran (both on my development computer and a separate build environment), but I'd like to ask anyone running 3.2.x to test it in more production-like environments.
The current state is available in git, but I've also uploaded a tarball to:
http://people.balabit.hu/bazsi/syslog-ng-3.2.4+20111022+0801.tar.gz
A couple of systemd packaging notes:
* the tarball includes two identical syslog-ng.service files
1) contrib/systemd/syslog-ng.service 2) examples/syslog-ng.service
The second one can be dropped as the first is the one thats gets installed (--withsystemdsystemunitdir)
Right, the files in doc/examples were removed in 3.3, removed them from 3.2 too. Thanks for noticing, I've commited a fix.
* the syslog-ng.service file in the 3.2 branch is different from the one in the 3.3 git tree: ---------- --- syslog-ng-3.2.git/contrib/systemd/syslog-ng.service ... +++ syslog-ng-3.3.git/contrib/systemd/syslog-ng.service ... @@ -6,6 +6,7 @@ ExecStartPre=/bin/systemctl stop systemd-kmsg-syslogd.service ExecStart=/usr/sbin/syslog-ng -F ExecReload=/bin/kill -HUP $MAINPID +StandardOutput=null
[Install] WantedBy=multi-user.target ----------
backported too.
* we have been experiencing very strange systemd/syslog-ng problems in Fedora 15 (and Fedora 16 Beta): some systems become completely unusable if we change the Sockets option in the syslog-ng.service file from syslog-ng.socket to syslog.socket as suggested by the systemd author. At the same time the line "StandardOutput=null" was also added to the syslog-ng.service file but it doesn't appears to be the source of the problem. Any help tracking this one will be appreciated ...
The change that appears to be causing the problems: -Sockets=syslog-ng.socket +Sockets=syslog.socket
More details: https://bugzilla.redhat.com/show_bug.cgi?id=742624
hmm... I seem to remember having a problem with systemd acquired sockets to remain in blocking mode. This was fixed after 3.2.4 was released in this patch: commit 2f214c4f87d944aa28d53e331a67b1fd88d9840f Author: Balazs Scheidler <bazsi@balabit.hu> Date: Wed Jun 22 12:50:53 2011 +0200 systemd: make sure the acquired fd is in non-blocking mode The fd acquired from systemd is in blocking mode, and syslog-ng didn't explicitly set it to non-blocking, causing syslog-ng to stall. This patch changes that, explicitly enables O_NONBLOCK and O_CLOEXEC on systemd acquired fds. Reported-By: Enrico Scholz <enrico.scholz@informatik.tu-chemnitz.de> Signed-off-by: Balazs Scheidler <bazsi@balabit.hu> -- Bazsi