Gergely Nagy <algernon@balabit.hu> writes:
I don't think it's ripe for a merge yet, there's a bit of work left to done still, at least in the code part. The functionality itself is - I believe - solid by now.
A couple of other notes I discovered just after hitting send: * The value-pairs testcase crashes. I don't yet know why, but it didn't do that before I made the transformations thread-safe. So I must have screwed something up there. * The ValuePairsTransformSet contains a GPatternSpec that it doesn't really need. It's exactly the same pattern we use for key(), so it's duplicated here. It should be value-pairs that checks whether a transformation needs to be applied or not, not the transformation set itself. This needs a bit of code-juggling to do, but is fairly straightforward, but I lack the time to do it tonight. * The test cases are... few and dumb. I promise I'll add more, complexer ones too. -- |8]