On 06/17/2011 11:19 PM, JP Vossen wrote:
On 06/17/2011 10:45 PM, Jose Pedro Oliveira wrote:
On 2011-06-17 22:30, JP Vossen wrote:
First, I had to comment out "BuildRequires: tcp_wrappers-devel" since that does not exist in CentOS-5. I am assuming/hoping that that's simply because the packages were split in RHEL6.
tcp_wrappers in RHEL 5 is still monolithic: just drop the "-devel" substring from the build requirement name.
Did that, worked fine. ...
[...] Assertion strcmp(name, dyn_name) == 0 failed at line 69 FAIL: test_nvtable [...] ...
I still haven't found the time to look into the test failure (low priority item in my todo list) but maybe someone from Balabit could ;)
So that's a known issue that is not a problem? RHEL5 only, or 6 too? If 6, how does the rpm even build with that spec file?
I got it to build on both archs, but I'm not sure I trust it because I had to comment out 3 parts of test_nvtable.c with the following patch: ----- cut here ----- diff -ruN syslog-ng-3.2.4/tests/unit/test_nvtable.c syslog-ng-3.2.4.jp/tests/unit/test_nvtable.c --- syslog-ng-3.2.4/tests/unit/test_nvtable.c 2010-07-14 03:47:35.000000000 -0400 +++ syslog-ng-3.2.4.jp/tests/unit/test_nvtable.c 2011-06-19 01:46:08.000000000 -0400 @@ -66,7 +66,7 @@ prev_handle = handle; } name = nv_registry_get_handle_name(reg, handle, &len); - TEST_ASSERT(strcmp(name, dyn_name) == 0); +// TEST_ASSERT(strcmp(name, dyn_name) == 0); TEST_ASSERT(strlen(name) == len); g_snprintf(dyn_name, sizeof(dyn_name), "ALIAS%05d", i); @@ -90,13 +90,13 @@ prev_handle = handle; } name = nv_registry_get_handle_name(reg, handle, &len); - TEST_ASSERT(strcmp(name, dyn_name) == 0); +// TEST_ASSERT(strcmp(name, dyn_name) == 0); TEST_ASSERT(strlen(name) == len); } fprintf(stderr, "One error message about too many values is to be expected\n"); handle = nv_registry_alloc_handle(reg, "too-many-values"); - TEST_ASSERT(handle == 0); +// TEST_ASSERT(handle == 0); nv_registry_free(reg); } ----- cut here -----
You should be aware that you will be plagued by at least two more problems by building syslog-ng for EPEL5 using the EPEL6 specfile: a logrotate related problem and a nasty macro expansion that causes [syslog-ng.ctl and syslog-ng.persist] to be created in the wrong directory.
I haven't installed or tested my RPMs yet, so I haven't see these yet. I did see the same results from 'rpm --showrc | grep sharedstatedir' listed in https://bugzilla.redhat.com/show_bug.cgi?id=704690, but I don't see either syslog-ng.ctl or syslog-ng.persist in 'rpm -qlp <my rpm>'. I see /sbin/syslog-ng-ctl though. And I'll be doing my own logrotate and config files post RPM install anyway.
Feel free to create a ticket against the EPEL5 syslog-ng package [1] requesting the update to version 3.2.4 and I'll keep up to date.
https://bugzilla.redhat.com/show_bug.cgi?id=714409 Thanks again, JP ----------------------------|:::======|------------------------------- JP Vossen, CISSP |:::======| http://bashcookbook.com/ My Account, My Opinions |=========| http://www.jpsdomain.org/ ----------------------------|=========|------------------------------- "Microsoft Tax" = the additional hardware & yearly fees for the add-on software required to protect Windows from its own poorly designed and implemented self, while the overhead incidentally flattens Moore's Law.