Thanks. I knew it wasn't difficult :) I completed a patch and added unit tests coverage for this code to avoid breaking it in the future. I've attributed it to your name with a signed-off-by line, which means that you contributed this code, as described here: https://www.balabit.com/network-security/syslog-ng/opensource-logging-system... Please let me know if this wasn't your intent. Thanks. On Thu, 2011-09-01 at 10:46 +0200, Sandor Geller wrote:
this was an easy one:
format_zone_info of timeutils.c doesn't handle the minute portion the same way as hours:
int format_zone_info(gchar *buf, size_t buflen, glong gmtoff) { return g_snprintf(buf, buflen, "%c%02ld:%02ld", gmtoff < 0 ? '-' : '+', (gmtoff < 0 ? -gmtoff : gmtoff) / 3600, (gmtoff % 3600) / 60); }
should get changed to something like this:
int format_zone_info(gchar *buf, size_t buflen, glong gmtoff) { return g_snprintf(buf, buflen, "%c%02ld:%02ld", gmtoff < 0 ? '-' : '+', (gmtoff < 0 ? -gmtoff : gmtoff) / 3600, ((gmtoff < 0 ? -gmtoff : gmtoff) % 3600) / 60); }
On Thu, Sep 1, 2011 at 8:17 AM, <bugzilla@bugzilla.balabit.com> wrote:
https://bugzilla.balabit.com/show_bug.cgi?id=132
--- Comment #1 from Balazs Scheidler <bazsi@balabit.hu> 2011-09-01 08:17:54 --- yes, it really seems to be a bug. we should take the abaolute value of the minute portion.
Timestamps are formatted in logstamp.c. can anyone give a shot on this? I'll, but would take some time until I get there. thanks.
-- Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes. ______________________________________________________________________________ Member info: https://lists.balabit.hu/mailman/listinfo/syslog-ng Documentation: http://www.balabit.com/support/documentation/?product=syslog-ng FAQ: http://www.balabit.com/wiki/syslog-ng-faq
______________________________________________________________________________ Member info: https://lists.balabit.hu/mailman/listinfo/syslog-ng Documentation: http://www.balabit.com/support/documentation/?product=syslog-ng FAQ: http://www.balabit.com/wiki/syslog-ng-faq
-- Bazsi