On Feb 3 08:38, Balazs Scheidler wrote:
Hi,
I got some negative feedback on the introduction of this shared object by the SUSE guys too. So I might go with the suggestion you made about symlinking pdbtool instead of this new shared library route.
Guys, what do you think?
I'm all for the symlink since it's much simpler than creating an extra shared lib, and it works on all platforms.
signed-off by Corinna Vinschen <vinschen@redhat.com>
diff --git a/modules/dbparser/Makefile.am b/modules/dbparser/Makefile.am index c906bcd..ee019bc 100644 --- a/modules/dbparser/Makefile.am +++ b/modules/dbparser/Makefile.am @@ -17,7 +17,7 @@ libsyslog_ng_patterndb_la_SOURCES = radix.c radix.h \ timerwheel.c timerwheel.h \ patternize.c patternize.h libsyslog_ng_patterndb_la_LDFLAGS = -no-undefined -libsyslog_ng_patterndb_la_LIBADD = @OPENSSL_LIBS@ @DEPS_LIBS@ +libsyslog_ng_patterndb_la_LIBADD = @OPENSSL_LIBS@ @DEPS_LIBS@ ../../lib/libsyslog-ng.la
module_LTLIBRARIES = libdbparser.la libdbparser_la_SOURCES = \
OTOH, using your proposal, the fix is rather simple, so I'll not complain if you stick to the shared lib. Corinna -- Corinna Vinschen Cygwin Project Co-Leader Red Hat