[tproxy] Problem with Tproxy more kernel2.6.22.9

[Laszlo Attila Toth]

Ming-Ching Tiew írta:
> Laszlo Attila Toth wrote:
>> I correct this in the next release, which will also contain patch for 
>> iptables 1.4.
>>
> 
> Because of the bridge problem mentioned in the list, I had to setup 
> bridge redirect target for packets to arrive at the real interfaces ( vs 
> br0 ). However, when doing so, if the real interface has no IP address, 
> it will cause kernel ooops due to accessing null pointers.
> 
> I made a small change here to avoid the kernel ooops :-
> 
> @@ -394,7 +394,7 @@
>      if (lport == 0)
>                lport = hp->dest;
>  
> -      if (laddr == 0)
> +      if (laddr == 0 && indev->ifa_list )
>                laddr = indev->ifa_list->ifa_local;
>  
>       DEBUGP(KERN_DEBUG "IPT_TPROXY: performing redirect to 
> %08x:%04x\n", laddr, lport);
> 
> Not sure it will be relevent to your next release. If not, kindly ignore.
> 
> Ming-Ching.
> 

Applied, thanks. The kernel oops is avoided, but the laddr has an 
invalid address.

Current version is in git:
http://git.balabit.hu/?p=panther/tproxy4.git;a=summary


-- 
Panther