[syslog-ng] [Bug 280] Memory leak in value-pairs.c

[bugzilla at bugzilla.balabit.com]

https://bugzilla.balabit.com/show_bug.cgi?id=280





--- Comment #2 from SpiroG <sgounaro at optonline.net>  2014-05-21 00:17:40 ---
Hi ,this does not solve it, it makes a little better but it still memory leaks...


I have added this:  g_ptr_array_foreach(tokens, (GFunc)g_free, NULL); at line 657 in value-pairs.c

to clear the items that the array points to before we free the array.

That solves the issue.


Thanks



(In reply to comment #1)
> Hi,
> 
> can you check if this patch fixes it for you?
> 
> diff --git a/lib/value-pairs.c b/lib/value-pairs.c
> index 2256758..d10587a 100644
> --- a/lib/value-pairs.c
> +++ b/lib/value-pairs.c
> @@ -618,7 +618,10 @@ vp_walker_name_value_split(const gchar *name)
>      vp_walker_name_value_split_add_name_token(array, name, &current_
> 
>    return array;
>  }
> 
> There was a proposed patch on github to fix this issue:
> 
> https://github.com/balabit/syslog-ng/pull/126
> 
> That fix is not correct though, this one definitely fixes a leak, I'm just not sure if this is the one that affects you.
> 


-- 
Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.