[syslog-ng] [Bug 269] some code doesn't follow glib recomendations

[bugzilla at bugzilla.balabit.com]

https://bugzilla.balabit.com/show_bug.cgi?id=269





--- Comment #5 from Balazs Scheidler <bazsi at balabit.hu>  2014-02-01 07:34:51 ---
(In reply to comment #4)
> In nv_registry_alloc_handle there is a check for self->name_map length: it should be less than 65535.
> If you store aliases in the same array with names you shrink available name quantity per table.

that check is not against name_map, but rather against "names", where aliases are not inserted, so this limit is not changed at all.


> I don't know what's the average use of an nv_table and if adding aliases into the same namespace can break anything, so it's up to you.
> The code itself is OK and seems to be fully functional in my case (I don't perform full functional tests, I only test some things I really need).

aliases should be in the same namespace, but shouldn't be counted in the limit. but they are not.

I'm committing this patch. 

I'm adding a signed-off-by tag on your behalf, please let me know if it's not ok for you.

The signed-off-by tag indicates that you rightfully submitted and contributed the patch, it is explained here

https://www.kernel.org/doc/Documentation/SubmittingPatches
Thanks.


-- 
Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.