[syslog-ng] [Bug 278] Many memory leak problems happen when do configuration reloading

[bugzilla at bugzilla.balabit.com]

https://bugzilla.balabit.com/show_bug.cgi?id=278


Tusa Viktor <tusavik at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tusavik at gmail.com




--- Comment #8 from Tusa Viktor <tusavik at gmail.com>  2014-04-23 19:32:28 ---
Hi Xufeng!

Sorry for the late answer, we didn't have any time to investigate the issues. Thank you for your patches.

I am trying to prepare your patches for integration. The first two are valid and fine, but for the third, casting the LogProtoClient back to
a LogProtoTextClient is a layering violation. We should unref the message if during the flush the proto cannot consume it, but it is the duty of the proto
to track it's internal thingies state. Oh, the situation is worse, partial comes from LogWriter's line_buffer, and we free it in LogProtoTextClient. Well,
that's 
kind of a mess, but I don't have energy to think about the correct solution. Next days I'm on a conference, but I'll try to figure out something by next week 
and I'll definitely take a look on your other patches. The current patches are on github, talien/syslog-ng repo, f/memory-leak-fixes branch. 
The last patch is not working (at least it does not really fix the leak).

Thank you for your effort!


-- 
Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.