[syslog-ng] [Bug 256] rewrite + subst make syslog-ng crash

[bugzilla at bugzilla.balabit.com]

https://bugzilla.balabit.com/show_bug.cgi?id=256


Balazs Scheidler <bazsi at balabit.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bazsi at balabit.hu




--- Comment #3 from Balazs Scheidler <bazsi at balabit.hu>  2013-10-23 20:39:47 ---
for now it is the proper fix, however it'll degrade performance a bit, as it'll clone messages even if the subst() pattern doesn't match...

I am pondering of a refactor of the LogMatcher code:
  - decouple it from LogMessage (and perhaps rename it to something without the Log prefix)
  - use callbacks (in as similar vein to ValuePairs) to return values to be added to the log message

Once that refactor is in place, we could delay the log_msg_make_writable() call into the callback, right now $0, $1 and so on are added to the LogMessage 
as the replacement template may reference them. it doesn't right now, but we don't know that.


-- 
Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.