[syslog-ng] [Bug 238] syslog-protocol: allow NILVALUE for TIMESTAMP as specified in rfc5424

[bugzilla at bugzilla.balabit.com]

https://bugzilla.balabit.com/show_bug.cgi?id=238


Gergely Nagy <algernon at balabit.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|                            |FIXED
             Status|ASSIGNED                    |RESOLVED




--- Comment #6 from Gergely Nagy <algernon at balabit.hu>  2013-07-04 13:47:55 ---
(In reply to comment #5)
> I do not see a similar pattern on the "error" path ( https://github.com/balabit/syslog-ng-3.4/blob/master/modules/syslogformat/syslog-format.c#L1090 ):
> '''
>   if (G_UNLIKELY(!success))
>     {
>       gchar buf[2048];
> 
>       self->timestamps[LM_TS_STAMP] = self->timestamps[LM_TS_RECVD];
> [... Nothing on timestamps afterwards ...]
> '''
> 
> Am I missing something/Is it intended ?

This copies LM_TS_RECVD to LM_TS_STAMP, with everything included, zone offsets and all, so all the magic of figuring things out is not needed there, as
LM_TS_RECVD should have it all figured out at this point.

Also, since I merged the patch to master, and the error path looks correct too, I'm closing this issue. The fix will be part of syslog-ng 3.4.3, but it is also
available on the master branch in git.


-- 
Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.