[syslog-ng] [Bug 217] Poor single thraded performance reading from a pip

Tue Jan 22 13:45:26 CET 2013

https://bugzilla.balabit.com/show_bug.cgi?id=217

Gergely Nagy <algernon at balabit.hu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|                            |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #6 from Gergely Nagy <algernon at balabit.hu>  2013-01-22 13:45:26 ---
Right, this is terribly embarassing. Back in May, when restoring fsync(yes) functionality, the order of arguments to one function was mixed up, so that
flush-lines was set as if it was fsync, and the value of fsync was set as flush-lines. This resulted in fsync() being permanently enabled, and flush-lines()
always being 0 or 1, and this led to horrible performance.

Back then, this passed my tests, as I only tested that fsync() gets called, and it did. Lesson learned, I need to do negative tests too.

Nevertheless, I corrected this mistake on 3.4's master: https://github.com/balabit/syslog-ng-3.4/commit/c5775b689720c811905ebf55ee07f16773126215.patch

-- 
Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.