[syslog-ng] [Bug 203] patterndb rule tag can not have a hyphen in the class attribute

bugzilla at bugzilla.balabit.com bugzilla at bugzilla.balabit.com
Thu Oct 11 12:43:04 CEST 2012


Gergely Nagy <algernon at balabit.hu> changed:

           What    |Removed                     |Added
                 CC|                            |algernon at balabit.hu
         AssignedTo|bazsi at balabit.hu            |algernon at balabit.hu

--- Comment #1 from Gergely Nagy <algernon at balabit.hu>  2012-10-11 12:43:04 ---
(In reply to comment #0)
> Just seems odd that the rule tag can not have a hyphen in the class attribute.
> I would expect (and prefer) that the pattern should be '[a-zA-Z0-9_/\.+:-]'

Quickly glancing through the code, I did not find any use of the class value other than as a value: there's no ${.class.this-or-that} variable or anything like
it, so the restriction sounds far too strict to me. On a first blink, I'd remove the restriction completely.

I'll see if I can find any other reason why the restriction may be present - if there's none, it should be removed or at least weakened to your suggestion.

Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

More information about the syslog-ng mailing list