[syslog-ng] [PATCH 3/3] lib/: Clear ivykis handlers before setting them

[Lennert Buytenhek]

On Tue, May 08, 2012 at 12:11:54AM +0200, Gergely Nagy wrote:

> > > The iv_fd_set_handler_in()/iv_fd_set_handler_out() functions are
> > > picky, and will abort() if we want to set a handler for an FD that
> > > already has handlers registered. To avoid that, whenever we want to
> > > set a handler, clear the old one first.
> >
> > Actually, that shouldn't happen.
> >
> > I'm looking at the code, and that looks like a bug -- probably
> > started happening when we started doing delayed flushing of fds
> > to the kernel.
> >
> > I think it's safe to just delete those abort() calls from
> > iv_fd_set_handler_{in,out,err}().
> 
> Oh, right. There *was* a change in ivykis that could affect the
> behaviour of iv_fd_set_handler_{in,out,err}()!
> 
> Thanks for the reminder. I'll submit a patch in ~10 hours or so, after
> testing with syslog-ng, unless you beat me to it.

Go for it.  You found the issue, you get the credit. :-)