[syslog-ng] [PATCH 3/3] lib/: Clear ivykis handlers before setting them

Lennert Buytenhek buytenh at wantstofly.org
Mon May 7 23:47:07 CEST 2012


On Mon, May 07, 2012 at 11:42:33PM +0200, Gergely Nagy wrote:

> The iv_fd_set_handler_in()/iv_fd_set_handler_out() functions are
> picky, and will abort() if we want to set a handler for an FD that
> already has handlers registered. To avoid that, whenever we want to
> set a handler, clear the old one first.

Actually, that shouldn't happen.

I'm looking at the code, and that looks like a bug -- probably
started happening when we started doing delayed flushing of fds
to the kernel.

I think it's safe to just delete those abort() calls from
iv_fd_set_handler_{in,out,err}().


More information about the syslog-ng mailing list