[syslog-ng] [Bug 159] on signal HUP program destinations are not closed

[bugzilla at bugzilla.balabit.com]

https://bugzilla.balabit.com/show_bug.cgi?id=159





--- Comment #1 from Balazs Scheidler <bazsi at balabit.hu>  2012-03-11 14:31:50 ---
Are you sure it affects 3.3.4? Here's a patch that should've fixed this, but that's already included in 3.3.4:

Author: Gergely Nagy <algernon at balabit.hu>  2011-12-02 15:37:34
Committer: Balazs Scheidler <bazsi at balabit.hu>  2011-12-21 13:38:26
Parent: 79fc32703615e045fca4c9aaf85b7ab2915e7ed4 (csvparser: fixed csv-parser() when applied to multiple log paths)
Child:  511e939f4199af3ae9aaa4a14b77c7f82863c16f (logsource: fixed potential division by zero exception)
Branches: master, pipe-owner-group, remotes/algernon/debian/3.3, remotes/algernon/debian/autobuilt/3.3, remotes/algernon/feature/3.3/ivykis/upstream,
remotes/algernon/feature/3.3/mongodb/flat-insert, remotes/algernon/feature/3.4/tf-uuid, remotes/algernon/patched/3.3, remotes/algernon/sandbox/3.4,
remotes/algernon/upstream/dfsg/3.3, remotes/algernon/upstream/mirror/3.3, remotes/algernon/upstream/mirror/3.4, remotes/github/master,
remotes/github/pipe-owner-group, remotes/origin/master
Follows: v3.3.3
Precedes: debian/v3.3.3.dfsg-1_mhp2+g511e939, v3.3.4

    afprog: Terminate the child process on deinit.

    When reloading the configuration, terminate the child process of a
    program destination, for the following reasons: it will be restarted
    anyway by afprog_dd_reopen(), so there's no harm done. But if dash is
    used as /bin/sh, simply closing the stdin of the process will not make
    it stop.

    That, in turn, results in us starting the same program over and over
    again on each SIGHUP. So instead of doing this, send a SIGTERM to the
    child on deinit, too.

    Reported-by: Thomas Wollner <tw at wollner-net.de>
    Signed-off-by: Gergely Nagy <algernon at balabit.hu>


-- 
Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.