[syslog-ng] Patch for tests/loggen.c (bind src addr and full SendQ sleep)

[Russell Tait Milne]

I can certainly add that signed off line for the patch submitted in this thread.

Signed-off-by: Russ Milne <rtaitmilne at seccuris.com>

I will look at the patch again in the near future to refactor it.

-Russ


-----Original Message-----
From: syslog-ng-bounces at lists.balabit.hu [mailto:syslog-ng-bounces at lists.balabit.hu] On Behalf Of Balazs Scheidler
Sent: January-31-12 8:38 AM
To: Syslog-ng users' and developers' mailing list
Subject: Re: [syslog-ng] Patch for tests/loggen.c (bind src addr and full SendQ sleep)

Hi,

I almost committed the ENOBUFS portion of the patch, which seems more or less ok. However I'd need a "Signed-off-by" line as described here:

https://www.balabit.com/network-security/syslog-ng/opensource-logging-system/community/contribution

It's not a copyright assignment, however it states that you willingly contributed the code in question to syslog-ng. It's nothing but an email that contains the patch and

Signed-off-by: name <email>

The other part, which adds the  --source option would need some refactoring.

1) it doesn't work on non-ipv6 systems
2) it copies the name resolution invocation, creating code duplication, which I'd love to see in a separate function.

Can you check if you could work on this patch a bit further to fix these issues? I'd appreciate that. Thanks.

On Fri, 2012-01-27 at 14:39 -0600, Russell Tait Milne wrote:
> A colleague of mine has patched the loggen utility to allow for:
>  - binding to a particular source address
>  - adding a usleep() when the SendQ is full
> 
> This patch was applied and tested on syslog-ng-3.3.3 found in the 
> FreeBSD ports tree.
> 
> I apologize in advance if this is not the proper way to submit a patch.
> (See attached patch)
> 
> Best,
> Russ
> 
> 
> 
> This communication, including any attachments, does not necessarily represent official policy of Seccuris Inc.
> 
> Please see http://www.seccuris.com/Contact-PrivacyPolicy.htm  for further details about Seccuris Inc.'s Privacy Policy.
> 
> If you have received this communication in error, please notify Seccuris Inc. at info at seccuris.com or at 1-866-644-8442.
> 
> ______________________________________________________________________
> ________ Member info: 
> https://lists.balabit.hu/mailman/listinfo/syslog-ng
> Documentation: 
> http://www.balabit.com/support/documentation/?product=syslog-ng
> FAQ: http://www.balabit.com/wiki/syslog-ng-faq
> 

--
Bazsi


______________________________________________________________________________
Member info: https://lists.balabit.hu/mailman/listinfo/syslog-ng
Documentation: http://www.balabit.com/support/documentation/?product=syslog-ng
FAQ: http://www.balabit.com/wiki/syslog-ng-faq

This communication, including any attachments, does not necessarily represent official policy of Seccuris Inc.
Please see http://www.seccuris.com/Contact-PrivacyPolicy.htm  for further details about Seccuris Inc.'s Privacy Policy.
If you have received this communication in error, please notify Seccuris Inc. at info at seccuris.com or at 1-866-644-8442.