[syslog-ng] [Bug 212] strange hostnames from /etc/hosts with threaded(yes);

[bugzilla at bugzilla.balabit.com]

https://bugzilla.balabit.com/show_bug.cgi?id=212





--- Comment #15 from Brian Kroth <bpkroth at gmail.com>  2012-12-21 16:54:38 ---
(In reply to comment #14)
> (In reply to comment #13)
> > (In reply to comment #12)
> > > (In reply to comment #10)
> > > > Created an attachment (id=68)
 --> (https://bugzilla.balabit.com/attachment.cgi?id=68) [details] [details] [details] [details]
> > > > patch to use reentrant versions of name lookup functions
> > > > 
> > > > This is a completely untested patch, I was not able to start it even once, but it does compile and should
> > > > the problem if the initial diagnosis is right.
> > > > 
> > > > I'm not sure how we couldn't find this one so far, probably the DNS cache has a high enough hit rate that
> > > > it doesn't get hit.
> > > > 
> > > > I'd appreciate feedback and will probably work on the patch when I return, but I gotta go now.
> > > 
> > > I tried to apply this to the 3.3.6 and 3.3.7 deb-src packages I was working with, but it didn't go down cleanly.  Do you have a pkg somewhere I can just use or
> > > some git references I should pull from instead?
> > > 
> > > Thanks,
> > > Brian
> > > 
> > 
> > This should apply cleanly to the 3.3.7 deb-src package:
> >  https://github.com/balabit/syslog-ng-3.3/commit/11b20b28f7586b2bf10c281328f28d93f39e279c.patch
> > 
> > I'll be preparing new Debian packages this friday or thereabouts, if all goes well. Until then, the fix is on the 3.3 git tree:
> > https://github.com/balabit/syslog-ng-3.3
> 
> Thanks.  I've rebuilt 3.3.7-1~mhp1 with this patch and am testing it now.  I'll let you know if I see any weird hostnames again.
> 
> Thanks,
> Brian

I haven't seen any weird hostnames yet, so I think this is working.

It is a little interesting that from 3.3.7 threaded(no) to threaded(yes) I actually see an increase in load average on the machine (.4 vs .8).  It's still sub
1 which is better than we were getting with 3.1 from stock debian, but still kinda curious.  My only guess is that with it having now multiple threads reading
and writing the disk IO pattern is somewhat different, but there again I'd expect the OS to buffer most of that and then stream it out later.  Anyways, thanks
for the help.

Brian


-- 
Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.