[syslog-ng] [Bug 212] strange hostnames from /etc/hosts with threaded(yes);

[bugzilla at bugzilla.balabit.com]

https://bugzilla.balabit.com/show_bug.cgi?id=212





--- Comment #11 from Gergely Nagy <algernon at balabit.hu>  2012-12-14 11:05:30 ---
(In reply to comment #10)
> Created an attachment (id=68)
 --> (https://bugzilla.balabit.com/attachment.cgi?id=68) [details]
> patch to use reentrant versions of name lookup functions

Looks fine to me, the locks around the non-reentrant paths are good to have too.

> This is a completely untested patch, I was not able to start it even once, but it does compile and should
> the problem if the initial diagnosis is right.

I ran a few tests, and the patch works as one would expect (in my case, I was testing the getnameinfo() branch, but I will test the other branches too, for
safety's sake).

> I'm not sure how we couldn't find this one so far, probably the DNS cache has a high enough hit rate that
> it doesn't get hit.

Indeed. I've been running threaded(yes) for a loooong time now, and never saw anything like this, not even on those hosts where I have a few dozen network
source-destination combos :/


-- 
Configure bugmail: https://bugzilla.balabit.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.