[syslog-ng] [PATCH 1/1] Add support for Unix sockets.
Gergely Nagy
algernon at balabit.hu
Thu Aug 16 15:41:40 CEST 2012
Gergely Nagy <algernon at balabit.hu> writes:
> "Conrad Hoffmann" <ch at bitfehler.net> writes:
>
>> I agree that this would be a far superior solution, and if you want me to
>> I would even try to help you a little.
>
> If you can do the 'baking in' before I get there on friday, that would
> be most appreciated :)
I got around to do it today, and did some more investigation. Turns out,
mongodb does not allow unix sockets in replicaset configs. But
nevertheless, I took your patch, then changed it to merge it behind a
common mongo_connect() (this way, mongo_sync_connect() did not need any
change at all, except for a documentation update).
I have not changed mongo_util_parse_addr(), because it's not needed
right now. If and when the mongodb folk figure out whether they want to
allow unix sockets in replicaset configs, we can update the parse_addr()
function and things will just work.
One thing of note, is that if you connect through a unix socket to a
replicaset, and you force a reconnect, you may end up being connected
via TCP instead. But that requires a few things to go bad, and I believe
this behaviour is fine.
I'll push the changes to github soon.
--
|8]
More information about the syslog-ng
mailing list