[syslog-ng] [PATCH] afmongodb: Support system-installed libmongo-client at configure time.

[Jakub Jankowski]

Hi,

first of all, sorry for bringing this old topic back.

Tuesday 19 of July 2011 20:55:54 Gergely Nagy wrote:
> Gergely Nagy <algernon at balabit.hu> writes:
> > Balazs Scheidler <bazsi at balabit.hu> writes:
> >>> The downside is that it requires glib >= 2.16, slightly newer than what
> >>> syslog-ng requires right now, but still pretty damn old (released
> >>> 2008-03-10, so more than 3 years old).
> [...]
> >> So is the glib dependency easy to get rid of, or it is something more
> >> inherent?
> [...]
> > All in all, it's reasonably easy to get rid of the hard 2.16 dependency,
> > and I'll do that for the next release.
>
> Done. libmongo-client 0.1.3 has been released as of an hour or so ago,
> tagged in git and all that. It removes the need for glib >= 2.16, and
> will work with 2.12 and up. When building with < 2.16, OpenSSL becomes a
> requirement, as I use its MD5 functions to emulate GChecksum.

It turns out this is not entirely true. HEAD of 3.3 does not compile on RHEL5, 
which has glib 2.12, because those 3 examples: 

modules/afmongodb/libmongo-client/examples/mongo-dump.c
modules/afmongodb/libmongo-client/examples/gridfs.c
modules/afmongodb/libmongo-client/examples/bson-inspect.c

use g_option_context_get_help(), which - according to documentation at 
http://developer.gimp.org/api/2.0/glib/ix09.html - is new in 2.14.

I've replaced g_option_context_get_help() occurences with simple static
gchar *help = "You must specify --this and --that\n";
and it seems to build fine.

Removind dependency on glib 2.14 would surely help some RHEL5-dependent folks 
like me. Please consider this, preferably before 3.3.0 final is out. :)


Regards,
 Jakub.

-- 
Jakub Jankowski|shasta at toxcorp.com|http://toxcorp.com/
GPG: FCBF F03D 9ADB B768 8B92 BB52 0341 9037 A875 942D