[syslog-ng] [PATCH 1/3] scratch-buffers: Scratch buffer implementation.

Gergely Nagy algernon at balabit.hu
Mon Oct 31 22:21:07 CET 2011


Balazs Scheidler <bazsi at balabit.hu> writes:

> Also, reset should be called _before_ calling the job function, and the
> full cleanup should be done once the thread finishes:
> main_loop_io_worker_thread_stop()
>
> Otherwise it looks nice.
>
> One whitespace nitpick that I'd care about is to start the name of the
> function on character 1, this makes it very easy to grep for the
> definition of the function.
>
> The others (using a space in front of '(') I don't care about as long as
> it's consistent within the same file. Since these are new files, they
> can be left as is.

Done (except for reset, see my other mails), and pushed to my
feature/3.4/scratch-buffers branch.

I fixed the space before parens too: there weren't many, and I usually
try to follow the existing style. I do fail at that from time to time,
that space is wired into my hands too deeply, I guess :)

-- 
|8]



More information about the syslog-ng mailing list