[syslog-ng] [PATCH 0/1]: value-pairs key rewriting for 3.4

[Gergely Nagy]

Gergely Nagy <algernon at balabit.hu> writes:

>> * The ValuePairsTransformSet contains a GPatternSpec that it doesn't
>>   really need. It's exactly the same pattern we use for key(), so it's
>>   duplicated here.
>>
>>   It should be value-pairs that checks whether a transformation needs to
>>   be applied or not, not the transformation set itself.
>>
>>   This needs a bit of code-juggling to do, but is fairly
>>   straightforward, but I lack the time to do it tonight.
>
> This proved to be trickier than anticipated, and I ran into a problem
> with not being happy with the current implementation of value-pairs at
> all. There's too much copying and magic going on for my taste.

Note to self: we can steal strings from scratch buffers, and thus make
things a little bit nicer.

We could also just pass ScratchBuffer GStrings into the transform
functions, and clean up the code considerably that way.

-- 
|8]