[syslog-ng] Duplicate configuration items causing memory leak

[Balazs Scheidler]

On Tue, 2011-11-08 at 11:39 -0800, Dave Rawks wrote:
> Sorry if this is a duplicate, I'm not sure it made it to the list on my
> first try...
> 
> > commit b061328b3e0d3b466ac29ef4e1b3ee384b7130b0 Author: Balazs 
> > Scheidler <bazsi at balabit.hu> Date:   Mon Oct 31 16:33:32 2011 
> > +0100
> > 
> > configuration: report duplicate configuration elements
> > 
> > Previously if a configuration element name was used twice, the 2nd 
> > would be used and some memory was leaked on every reload.
> > 
> > This patch changes that by reporting duplicate IDs as configuration 
> > errors.
> > 
> > A patch was posted by Anthony, but a different implementation was 
> > used instead.
> > 
> > Reported-By: anthony lineham <anthony.lineham at alliedtelesis.co.nz>
> > Signed-off-by: Balazs Scheidler <bazsi at balabit.hu>
> 
> Does this patch break the behavior described in the documentation for
> 3.3.1?
> 
> > If an object is defined twice (for example the original syslog-ng 
> > configuration file and the file imported into this configuration
> > file both define the same option, source, or other object), then the 
> > object that is defined later in the configuration file will be 
> > effective. For example, if you set a global option at the beginning 
> > of the configuration file, and later include a file that defines the 
> > same option with a different value, then the option defined in the 
> > imported file will be used.
> 
> If you cannot overload previously defined objects then the ability to
> include config files becomes FAR less useful imho.

uhm, uhm. Yes it does. I didn't know this was a documented feature :)

This could be controlled (possibly by a configuration variable), but
before I do that could you explain your usecase, which makes include
files to be less useful?

thanks.


-- 
Bazsi