[syslog-ng] syslog-ng 3.2.3 build failure

[Balazs Scheidler]

Hi,

Thanks for the patch and sorry for the mistake. I guess I'll wait a
couple of days and release 3.2.4 in case some other problems are found.

Since I'd like to give credit where it is due, can you please include a
Signed-off-by line to indicate your authorship?

It is enough to copy-paste it as a reply to this email, the point is
that the complete patch is visible.

Thanks.

On Mon, 2011-05-02 at 14:10 +0200, Sandor Geller wrote:
> Hello,
> 
> The below change breaks linking syslog-ng-ctl on OSes where the
> resolver library provides inet_aton so the -lresolv linker flag is
> needed. So far I ran into the issue only on Solaris 8 which isn't a
> modern OS I know...
> 
> --- syslog-ng-3.2.2/syslog-ng/Makefile.in       2011-01-15
> 17:15:10.000000000 +0100
> +++ syslog-ng-3.2.3/syslog-ng/Makefile.in       2011-05-01
> 21:47:51.000000000 +0200
> @@ -60,7 +60,7 @@
>  syslog_ng_DEPENDENCIES =
>  am_syslog_ng_ctl_OBJECTS = syslog-ng-ctl.$(OBJEXT)
>  syslog_ng_ctl_OBJECTS = $(am_syslog_ng_ctl_OBJECTS)
> -syslog_ng_ctl_DEPENDENCIES = ../lib/libsyslog-ng.la
> +syslog_ng_ctl_DEPENDENCIES = ../lib/gsocket.lo ../lib/gsockaddr.lo
>  am_syslog_ng_wrapper_OBJECTS = wrapper.$(OBJEXT)
>  syslog_ng_wrapper_OBJECTS = $(am_syslog_ng_wrapper_OBJECTS)
>  syslog_ng_wrapper_LDADD = $(LDADD)
> 
> The fix seems to be trivial and hopefully doesn't have side-effects on any OS:
> 
> --- syslog-ng-3.2.3/configure.in        2011-05-01 21:46:51.000000000 +0200
> +++ syslog-ng-3.2.3-hacked/configure.in 2011-05-02 14:06:27.000000000 +0200
> @@ -845,6 +845,7 @@
>  AC_SUBST(SOURCE_REVISION)
>  AC_SUBST(PACKAGE_FILES_SUFFIX)
>  AC_SUBST(PACKAGE_SUFFIX)
> +AC_SUBST(RESOLV_LIBS)
> 
> 
>  AC_OUTPUT(dist.conf
> diff -urN syslog-ng-3.2.3/syslog-ng/Makefile.am
> syslog-ng-3.2.3-hacked/syslog-ng/Makefile.am
> --- syslog-ng-3.2.3/syslog-ng/Makefile.am       2011-02-23
> 11:15:06.000000000 +0100
> +++ syslog-ng-3.2.3-hacked/syslog-ng/Makefile.am        2011-05-02
> 13:53:44.000000000 +0200
> @@ -19,7 +19,7 @@
>  syslog_ng_wrapper_SOURCES = wrapper.c
> 
>  syslog_ng_ctl_SOURCES = syslog-ng-ctl.c
> -syslog_ng_ctl_LDADD = ../lib/gsocket.lo ../lib/gsockaddr.lo
> @BASE_LIBS@ @GLIB_LIBS@
> +syslog_ng_ctl_LDADD = ../lib/gsocket.lo ../lib/gsockaddr.lo
> @BASE_LIBS@ @GLIB_LIBS@ @RESOLV_LIBS@
> 
>  if ENABLE_ENV_WRAPPER
> 
> Regards,
> 
> Sandor
> ______________________________________________________________________________
> Member info: https://lists.balabit.hu/mailman/listinfo/syslog-ng
> Documentation: http://www.balabit.com/support/documentation/?product=syslog-ng
> FAQ: http://www.campin.net/syslog-ng/faq.html
> 
> 

-- 
Bazsi