[syslog-ng] [RFC/RFR] value-pairs() code preview

Gergely Nagy algernon at balabit.hu
Fri Mar 25 18:47:20 CET 2011


Gergely Nagy <algernon at balabit.hu> writes:

> TODO
> ====
>
> * Support SEQNUM

This will need a little API change, I believe. But I'm still exploring
my options.

> * Possibly filter out empty, zero-length values, since they're kinda
>   useless.

This is done on the head of my git branch.

> * Performance tuning:
>   + Pre-allocate LogTemplate structures, if possible

Done too.

>   + Try to reduce the number of memory allocations

Done too, to some extent, there's still a few areas where things could
be improved.

Looking at a few callgrind results, it looks like GHashTable is one of
the bottle necks, so the next batch of commits will try to move away
from that to something else. Perhaps something which needs less data
copying.

-- 
|8]


More information about the syslog-ng mailing list